1010082 - mach: mach dxr goes to the wrong url

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Reproduce steps:
1. mach dxr marionette
2. The browser open a page "404 Not Found".

Comment 2

[Boris Chiou [:boris]]

Attachment: 404_Not_Found_screenshot

I can reproduce it. Please check my screenshot.

Comment 3

[Ed Morley [:emorley]]

Attachment: Fix |mach dxr| URL

Please can you confirm these are the most appropriate query params (trying in-browser had one that had redirect=true, wasn't sure if I should preserve that).

Comment 4

[Erik Rose [:erik][:erikrose]]

You should probably keep the "redirect=true" in there. It allows DXR's "direct search" feature, which takes you straight to a method definition (for instance) if one exactly matches your search string.

Comment 5

[Ed Morley [:emorley]]

Attachment: Fix |mach dxr| URL

Done :-)

Comment 6

[Ed Morley [:emorley]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/2ba9cda30f62

Comment 7

[Erik Rose [:erik][:erikrose]]

Comment on attachment 8422473 [details] [diff] [review]
Fix |mach dxr| URL

Review of attachment 8422473 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2ba9cda30f62