Closed Bug 1010082 Opened 5 years ago Closed 5 years ago

mach: mach dxr goes to the wrong url

Categories

(Firefox Build System :: Mach Core, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla32

People

(Reporter: TYLin, Assigned: emorley)

Details

Attachments

(2 files, 1 obsolete file)

No description provided.
Reproduce steps:
1. mach dxr marionette
2. The browser open a page "404 Not Found".
I can reproduce it. Please check my screenshot.
Attached patch Fix |mach dxr| URL (obsolete) — Splinter Review
Please can you confirm these are the most appropriate query params (trying in-browser had one that had redirect=true, wasn't sure if I should preserve that).
Attachment #8422325 - Flags: review?(erik)
Assignee: nobody → emorley
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
You should probably keep the "redirect=true" in there. It allows DXR's "direct search" feature, which takes you straight to a method definition (for instance) if one exactly matches your search string.
Done :-)
Attachment #8422325 - Attachment is obsolete: true
Attachment #8422325 - Flags: review?(erik)
Comment on attachment 8422473 [details] [diff] [review]
Fix |mach dxr| URL

Review of attachment 8422473 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!
Attachment #8422473 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/2ba9cda30f62
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.