1010096 - Display add-ons in alphabetical order in about:addons

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Add-on Manager, defect)

Description

[:Margaret Leibovic]

The (lack of) logic for this is here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutAddons.js#243

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Spoke w/ vik123 on IRC.

Comment 2

[vikneshwar]

Attachment: addon.patch

Comment 3

[:Margaret Leibovic]

Comment on attachment 8427734 [details] [diff] [review]
addon.patch

Review of attachment 8427734 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent! I just have one small style comment for you to address. You should upload a new version of the patch that addresses that, and then you can set the checkin-needed keyword on the bug for someone to come commit it for you! :)

::: mobile/android/chrome/content/aboutAddons.js
@@ +247,5 @@
>        let list = document.getElementById("addons-list");
>        list.innerHTML = "";
>  
> +      aAddons.sort(function(a,b) {
> +          return a.name.localeCompare(b.name);

Nit: We use 2-space indentation in our JavaScript code.

Comment 4

[vikneshwar]

Attachment: addon-updated.patch

Comment 5

[:Margaret Leibovic]

Comment on attachment 8427977 [details] [diff] [review]
addon-updated.patch

Review of attachment 8427977 [details] [diff] [review]:
-----------------------------------------------------------------

Great! I also should have mentioned that we generally only use the checkin flag on patches if there is a large series of patches in a bug that are landing incrementally. Instead, we use a keyword on the bug. Confusing, I know!

Comment 6

[vikneshwar]

Yeah got it ;)

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/a21a0801e55f

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a21a0801e55f

Comment 9

[Teodora Vermesan (:TeoVermesan)]

Add-ons are in an alphabetical order in about:addons, so:
Verified fixed on:
Device: LG Nexus 4 (Android 4.4.2)
Build: Firefox for Android 32.0a1 (2014-05-27)