1010162 - Follow up 1008144 - Decouple layout logic from app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Comment 1

[Kevin Grandon :kgrandon]

So this is interesting because something everything.me wants to do is to be able to reuse grid logic for smart collections. Perhaps we should design some API so that it can be used in either case (a homescreen grid, or a collection grid).

I'm not sure what the API should look like, but something off the top of my head: 

var grid = new Grid(document.getElementById('folder'));
grid.mixin(Dragdrop);
grid.mixin(EditMode);
grid.mixin(Zoom);
grid.render();

Comment 2

[Cristian Rodriguez (:crdlc)]

It sounds good although the goal of this bug was only to remove this

if (!this.stopped) {
  document.body.dataset.cols = layout.perRow;
}

from app.js as you suggested to me in the last review of the bug 1008144 :)

(In reply to Kevin Grandon :kgrandon from comment #1)
> So this is interesting because something everything.me wants to do is to be
> able to reuse grid logic for smart collections. Perhaps we should design
> some API so that it can be used in either case (a homescreen grid, or a
> collection grid).
> 
> I'm not sure what the API should look like, but something off the top of my
> head: 
> 
> var grid = new Grid(document.getElementById('folder'));
> grid.mixin(Dragdrop);
> grid.mixin(EditMode);
> grid.mixin(Zoom);
> grid.render();

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Are you comfortable with this idea?

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8422459 [details]
Patch v1

Everything seems to work, thanks!

Comment 5

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/3a1d67246a79e3632c3b3f2460a25291e7e2714c

Comment 6

[Kevin Grandon :kgrandon]

Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.