Closed
Bug 1010271
Opened 11 years ago
Closed 11 years ago
The debug button stays active (although disabled) even after the app is stopped
Categories
(DevTools Graveyard :: WebIDE, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 32
People
(Reporter: sole, Assigned: paul)
References
Details
Attachments
(1 file)
|
1.01 KB,
patch
|
janx
:
review+
jryans
:
review+
|
Details | Diff | Splinter Review |
If I'm running an app in the simulator and I press "debug", the button turns to blue ("active"). But if I stop it, the debug button is still blueish (albeit disabled). If I press play again the button is still blue but it shouldn't because I still haven't started debugging.
| Assignee | ||
Comment 1•11 years ago
|
||
| Assignee | ||
Updated•11 years ago
|
Attachment #8424429 -
Flags: review?(jryans) → review?(janx)
Comment 2•11 years ago
|
||
Comment on attachment 8424429 [details] [diff] [review]
v1
Review of attachment 8424429 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM (assuming we always receive a `toolbox-close` message when the toolbox closes somehow).
Attachment #8424429 -
Flags: review?(janx) → review+
| Assignee | ||
Updated•11 years ago
|
Attachment #8424429 -
Flags: review?(jryans)
Comment on attachment 8424429 [details] [diff] [review]
v1
Review of attachment 8424429 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM. Please use 8 lines of context in the future!
Attachment #8424429 -
Flags: review?(jryans) → review+
| Assignee | ||
Comment 4•11 years ago
|
||
To the sheriff: this doesn't require to go through try, this code is not compiled yet.
Keywords: checkin-needed
Comment 5•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
Updated•7 years ago
|
Product: Firefox → DevTools
Updated•6 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•