Closed Bug 1010402 Opened 7 years ago Closed 7 years ago

Clickable area of sync datatypes too large


(Firefox :: Sync, defect)

Not set



Firefox 32


(Reporter: rfeeley, Assigned: rittme)


(Whiteboard: [good first bug][mentor=mconley] p=0 s=33.1 [qa!])


(4 files, 1 obsolete file)

Attached image hit-area.gif
Currently the hit (clickable) area of the sync datatype selections is a full block, but should be limited to just the checkbox and its label. When the hit area is too large, users may accidentally provide their account with personal data, like saved passwords, they may not intend to.
Sounds like my fix for bug 982167 just needs porting to the data type selection dialog (browser/base/content/sync/customize.xul).
Flags: firefox-backlog+
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [good first bug][mentor=gavin]
Attached image signin.gif
Also an issue in the unauthenticated state. See attached.
Relabeling good-next; this looks straightforward, but touching UX and migrating a fix means it's not a starter bug.
Whiteboard: [good first bug][mentor=gavin] → [good next bug][mentor=gavin]
I disagree - this bug is very easy to test, requires minimal changes, and that there is an existing patch that illustrates the general approach makes it easier, not harder.
Whiteboard: [good next bug][mentor=gavin] → [good first bug][mentor=gavin]
I would like to work on this bug, if someone could assign me to it, please.

Also, there is the same problem at the Manage label.
Assignee: nobody → bernardo
So Bernardo, I originally thought that this would be a WONTFIX since it's not a problem in in-content prefs - but with in-content prefs being blocked by a number of things and maybe-not shipping for a few releases, I think we should try to tackle this anyways.

I think it'd be good to cut your teeth on.

Let me know if you have any questions about this bug (please needinfo me - see next to the "Save Changes" button at the bottom of this page - just put my e-mail address in there).
Nice! So I have some questions about the backporting of this bug and the repository I should use.

I can reproduce the label bugs in aurora and release, but the checkboxes are already working fine in Aurora (on Windows and Linux).

Should I work the patch using mozilla-central repository or should I use another release?
Flags: needinfo?(mconley)
Hey Bernardo,

You should start working on mozilla-central first, and then we can backport to mozilla-aurora and beta if necessary.
Flags: needinfo?(mconley)
Attached patch rev1 sync clickable areas fix (obsolete) — Splinter Review
I think this should work. 
I used the approach Gavin suggested (like in bug 982167).
Attachment #8435661 - Flags: review?(mconley)
Flags: needinfo?(mconley)
While working on bug 1020422 I found out a cleaner solution using the align="start" attribute.
Attachment #8435661 - Attachment is obsolete: true
Attachment #8435661 - Flags: review?(mconley)
Attachment #8435827 - Flags: review?(mconley)
Comment on attachment 8435827 [details] [diff] [review]
rev2 sync clickable areas fix

Review of attachment 8435827 [details] [diff] [review]:

This code looks good to me! I've also tested it, and can confirm this resolves the issues when applied.

Thanks Bernardo! Great work!
Attachment #8435827 - Flags: review?(mconley) → review+
Hey Marco, mind adding this to the current iteration? Bernardo's got this in the bag.
Flags: needinfo?(mconley) → needinfo?(mmucci)
Whiteboard: [good first bug][mentor=gavin] → [good first bug][mentor=mconley]
Added to Iteration 32.3
Flags: needinfo?(mmucci)
Whiteboard: [good first bug][mentor=mconley] → [good first bug][mentor=mconley] p=0 s=it-32c-31a-30b.3 [qa?]
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=mconley] p=0 s=it-32c-31a-30b.3 [qa?] → [good first bug][mentor=mconley] p=0 s=it-32c-31a-30b.3 [qa?][fixed-in-fx-team]
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=mconley] p=0 s=it-32c-31a-30b.3 [qa?][fixed-in-fx-team] → [good first bug][mentor=mconley] p=0 s=it-32c-31a-30b.3 [qa?]
Target Milestone: --- → Firefox 32
Whiteboard: [good first bug][mentor=mconley] p=0 s=it-32c-31a-30b.3 [qa?] → [good first bug][mentor=mconley] p=0 s=33.1 [qa?]
Whiteboard: [good first bug][mentor=mconley] p=0 s=33.1 [qa?] → [good first bug][mentor=mconley] p=0 s=33.1 [qa+]
QA Contact: camelia.badau
Verified on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.8.5 using latest Aurora 32.0a2 (buildID: 	20140611004004) and the only remaining problem is the one mentioned in bug 1023339 ("for the Sync tab, when FxA account is connected, the clickable area is NOT limited to the checkbox and it's label").
Whiteboard: [good first bug][mentor=mconley] p=0 s=33.1 [qa+] → [good first bug][mentor=mconley] p=0 s=33.1 [qa!]
You need to log in before you can comment on or make changes to this bug.