1010473 - Fix stand-alone TART and tscrollx (Profiler.js broken)

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Avi Halachmi (:avih)]

Attachment: bugBrokenProfiler.js.v1.diff

Profiler.js which was added (at 3 places) in bug 967635 is missing:
- License clause.
- Note that it's duplicated.
- dumpLog is undefined on stand alone use (TART addon or tscroll pages).
- The 'Profiler' object doesn't have methods if the profiler is not available.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8422658 [details] [diff] [review]
bugBrokenProfiler.js.v1.diff

Review of attachment 8422658 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for the good cleanup here!

::: talos/page_load_test/tart/addon/content/Profiler.js
@@ +26,5 @@
>  
>    try {
>      netscape.security.PrivilegeManager.enablePrivilege('UniversalXPConnect');
>      _profiler = Components.classes["@mozilla.org/tools/profiler;1"].getService(Components.interfaces.nsIProfiler);
> +  } catch (ex) { (typeof(dumpLog) == "undefined" ? dump : dumpLog)(ex + "\n"); }

does == work, or should we === ?

Comment 2

[Avi Halachmi (:avih)]

(In reply to Joel Maher (:jmaher) from comment #1)
> does == work, or should we === ?

Yeah, == is good.

Thanks.

https://hg.mozilla.org/build/talos/rev/c4f3254f6d1a

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

are we waiting on deployment of this to m-c before closing it?

Comment 4

[Avi Halachmi (:avih)]

Just adding for reference, that AFAIK we still didn't test this change in production, and don't yet know that it doesn't break talos profiling or even normal talos runs.