Closed Bug 1010473 Opened 6 years ago Closed 6 years ago

Fix stand-alone TART and tscrollx (Profiler.js broken)

Categories

(Testing :: Talos, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: avih, Assigned: avih)

References

Details

(Keywords: ateam-talos-task)

Attachments

(1 file)

Profiler.js which was added (at 3 places) in bug 967635 is missing:
- License clause.
- Note that it's duplicated.
- dumpLog is undefined on stand alone use (TART addon or tscroll pages).
- The 'Profiler' object doesn't have methods if the profiler is not available.
Attachment #8422658 - Flags: review?(jmaher)
Comment on attachment 8422658 [details] [diff] [review]
bugBrokenProfiler.js.v1.diff

Review of attachment 8422658 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for the good cleanup here!

::: talos/page_load_test/tart/addon/content/Profiler.js
@@ +26,5 @@
>  
>    try {
>      netscape.security.PrivilegeManager.enablePrivilege('UniversalXPConnect');
>      _profiler = Components.classes["@mozilla.org/tools/profiler;1"].getService(Components.interfaces.nsIProfiler);
> +  } catch (ex) { (typeof(dumpLog) == "undefined" ? dump : dumpLog)(ex + "\n"); }

does == work, or should we === ?
Attachment #8422658 - Flags: review?(jmaher) → review+
(In reply to Joel Maher (:jmaher) from comment #1)
> does == work, or should we === ?

Yeah, == is good.

Thanks.

https://hg.mozilla.org/build/talos/rev/c4f3254f6d1a
are we waiting on deployment of this to m-c before closing it?
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Just adding for reference, that AFAIK we still didn't test this change in production, and don't yet know that it doesn't break talos profiling or even normal talos runs.
Depends on: 1016089
You need to log in before you can comment on or make changes to this bug.