1010598 - Remove COPPA screen from FxA FTE flow

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FxA, defect, P2)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

We only want to show the COPPA screen if we are *not* in the FTE.

Opening a bug to remove this from FTE.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I have a fix for this, but it depends on changes in bug 980638.

https://github.com/6a68/gaia/tree/bug-1010598-remove-coppa-fxa-fte

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Github PR 19652

Now that bug 980638 has landed, I've rebased this patch and pushed to Travis.

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 8428844 [details] [review]
Github PR 19652

Hi Fernando,

One more review for you. This is a bit more involved - we add FTU state awareness to the email picker screen, and skip COPPA if we're in FTU. Added a test for this new flow, and Travis is green.

Thanks,

Jared

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8428844 [details] [review]
Github PR 19652

The code looks good, but I am curious about why don't we want to show the COPPA screen in the FTU?

Comment 5

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Thanks, Fernando!

Product would like to streamline the FTU experience as much as possible. Product and legal discussed this (I think), and my understanding is that, if a child has a mobile device, then their parent/guardian must have given it to them, so there is implied consent for the child to use the device.

Comment 6

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Master: https://github.com/mozilla-b2g/gaia/commit/5e3967d53106b47d50f5c7333ec8d2d7cfd8379d

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 8428844 [details] [review]
Github PR 19652

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:

We want to remove COPPA screen from FTU flow to minimize the number of steps needed to sign up for Firefox Accounts. As I understand the product stance on this: if a child has a mobile device, we can assume that their parent/guardian gave them the mobile device, which counts as consent in COPPA terms.

[Testing completed]:

Unit test added to exercise this new conditional path.
Manually verified on Flame by developer.

[Risk to taking this patch] (and alternatives if risky):

Low/medium risk: 14 lines of JS changed in 1 screen of FxA signup flow, doesn't directly interact with other modules.

[String changes made]:

None

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 8428844 [details] [review]
Github PR 19652

Approving given FxA is new in 2.0 and given we are early in the cycle to take low risk changes like these to help with a new feature.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/780bc51fe037b014f997e8cf419571599a649e28

Comment 10

[Coler]

There are two situations in verifyed result:
1).Test with FTE by resetting phone, this issue is verified passed.
2).Test with FTU in Developor, this issue is verified failed.
Reproducing rate: 5/5
See attachment: Verify_Flame_COPPA.mp4,logcat_0259.txt
Occurrence time:2:59

STRs:
1. Launch settings->developor,tap "Launch First Time Use".
2. switch to "Firefox Account" view.
3. Tap "Create Account or Sign in".
4. Input account.

Actual Result:
4. It will prompt to select age.

Excepted Result:
4. The age Verification shouldn't be  popped up.

Flame2.0 build version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141130000204
Version         32.0

Flame2.1 build version:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0

Comment 11

[Coler]

Attachment: logcat_0259.txt

Comment 12

[Coler]

Attachment: Verify_Flame_COPPA.MP4