Open Bug 101064 Opened 23 years ago Updated 2 years ago

rework ConvertAndLoadComposeWindow() to avoid copying entire body on reply

Categories

(MailNews Core :: Composition, defect)

defect

Tracking

(Not tracked)

People

(Reporter: sspitzer, Unassigned)

Details

(Keywords: perf)

fix ConvertAndLoadComposeWindow() to avoid copying entire body on reply in BuildBodyMessageAndSignature() we do this: m_compFields->GetBody(&bod); // allocate and copy nsAutoString bodStr(bod); // copy again call ConvertAndLoadComposeWindow() which need access to the buffer because it calls TranslateLineEnding() there's probably more copying going on. note, there's another caller to ConvertAndLoadComposeWindow(), so keep that in mind. I'm positive we can rework the code to remove at one of the times we copy, probably more. varada, while working on this, I'd suggest stepping through and looking for other instances where we copy the body that we can fix.
Keywords: perf
OS: Windows 2000 → All
QA Contact: sheelar → stephend
Hardware: PC → All
Keywords: nsbeta1
Keywords: nsbeta1nsbeta1+
Priority: -- → P1
Target Milestone: --- → mozilla0.9.7
Target Milestone: mozilla0.9.7 → mozilla0.9.8
reassigning to sspitzer as part of work on reply perf.
Assignee: varada → sspitzer
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Status: NEW → ASSIGNED
Keywords: nsbeta1+nsbeta1-
Target Milestone: mozilla0.9.9 → mozilla1.2
Product: MailNews → Core
Assignee: sspitzer → nobody
Status: ASSIGNED → NEW
Priority: P1 → --
QA Contact: stephend → composition
Target Milestone: mozilla1.2alpha → ---
Product: Core → MailNews Core
Severity: normal → minor
Severity: minor → S4
You need to log in before you can comment on or make changes to this bug.