Closed Bug 1010727 Opened 10 years ago Closed 10 years ago

[NFC] nfcd hang if disable NFC when p2p connection is established

Categories

(Firefox OS Graveyard :: NFC, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S2 (23may)

People

(Reporter: dimi, Assigned: dimi)

Details

(Whiteboard: [p=1])

Attachments

(1 file, 1 obsolete file)

If there is a p2p connection established and we disable NFC at this moment. Sometimes nfcd hang.
Attached patch Patch v1 (obsolete) — Splinter Review
Root cause - sometimes after we already disable NFC, then we receive llcp deactivate notification. At this time we will call resetRfField function but actually NFC is disabled so there will be no responding for this API call.

Solution - check state before call resetRfFieldAPI.

Note.resetRFField API called in NFCService should be removed once secure element patch landing (bug 979868).
Attachment #8423001 - Flags: review?(allstars.chh)
Comment on attachment 8423001 [details] [diff] [review]
Patch v1

Review of attachment 8423001 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, but please use github.
Attachment #8423001 - Flags: review?(allstars.chh)
Attachment #8423001 - Attachment is obsolete: true
Attachment #8423031 - Flags: review?(allstars.chh)
Attachment #8423031 - Flags: review?(allstars.chh) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: