Closed
Bug 1010742
Opened 11 years ago
Closed 11 years ago
Improve performance in dragdrop
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(feature-b2g:2.0, b2g-v2.0 fixed)
| Tracking | Status | |
|---|---|---|
| b2g-v2.0 | --- | fixed |
People
(Reporter: crdlc, Assigned: crdlc)
References
Details
(Whiteboard: [systemsfe])
Attachments
(3 files)
Tasks to do:
1. Avoid some repaints
2. Just to render icons involved in the path between source and target icons
3. Add threshold to start drop animation
4. Clean a bit the code
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•11 years ago
|
Blocks: vertical-homescreen
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Comment 3•11 years ago
|
||
Hi Kevin, this patch improves the performance of the dragdrop in the vertical homescreen. Please review carefully my patch because I am not familiar with this code as you are, so I could have added some regression or edge case thought. Don't be very hard with me hahaha. Thanks mate for your time
Attachment #8423047 -
Flags: review?(kgrandon)
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8423047 [details]
Github pull request
Hey - this is looking pretty good! There's still some problems with the bottom of the page and dragging icons over the last divider. Again, this is likely a result of the from/to handling. I think it's going to be tricky to get that part right, so I might recommend handling that as it's own patch. Perhaps we could just handle the delay/timeout part in this bug? That is looking pretty solid.
Attachment #8423047 -
Flags: review?(kgrandon) → feedback+
|
|
||
Updated•11 years ago
|
feature-b2g: --- → 2.0
|
|
||
Comment 5•11 years ago
|
||
Also some of this may have been caught with better unit/integration testing. I'll try to do more of that in the next few weeks.
|
|
||
Updated•11 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S2 (23may)
|
|
Assignee | |
Comment 6•11 years ago
|
||
Comment on attachment 8423047 [details]
Github pull request
thanks
Attachment #8423047 -
Flags: review?(kgrandon)
|
|
||
Comment 7•11 years ago
|
||
Comment on attachment 8423047 [details]
Github pull request
Looks good, and I couldn't find any breakage. Thanks for the work on this!
Attachment #8423047 -
Flags: review?(kgrandon) → review+
|
|
||
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
status-b2g-v2.0:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•