1010764 - Make empty tab thumbnails visually consistent

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Ian Barlow (:ibarlow)]

Our about:home placeholder thumbs are different from our "empty" thumbnails where we either don't yet have a page thumbnail or we lose it. 

http://cl.ly/image/3d1v2p1N0l2X

It's pretty bad, and something we just keep forgetting to fix. My 2 minute fix idea is that we should use the same placeholder thumbnails everywhere. So take the one we use for about:home, and use that for missing thumbnails as well. 

Anthony and I are going to revisit the look of that placeholder, will post new graphcis shortly.

Comment 1

[Ian Barlow (:ibarlow)]

Attachment: blank tab icons.zip

Updated tab thumbnail images attached. Screenshot for reference: http://cl.ly/image/46322q0C0g34

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Use same placeholder image on all tabs (r=mfinkle)

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 8423798 [details] [diff] [review]
Use same placeholder image on all tabs (r=mfinkle)

Redirecting review.

Comment 4

[:Margaret Leibovic]

Comment on attachment 8423798 [details] [diff] [review]
Use same placeholder image on all tabs (r=mfinkle)

Review of attachment 8423798 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 5

[Peter Retzer (:pretzer)]

Can you make sure that the icon is vertically centered before landing? See the older bug 912512. :-)
Not sure if that was a code or an asset issue... Thanks!

Comment 6

[Lucas Rocha (:lucasr)]

(In reply to Peter Retzer (:pretzer) from comment #5)
> Can you make sure that the icon is vertically centered before landing? See
> the older bug 912512. :-)
> Not sure if that was a code or an asset issue... Thanks!

Yeah, the new image looks vertically centered, thanks for pointing this out :-)

Comment 7

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/25d80d76348d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/25d80d76348d