Closed
Bug 1010764
Opened 11 years ago
Closed 11 years ago
Make empty tab thumbnails visually consistent
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(fennec32+)
RESOLVED
FIXED
Firefox 32
| Tracking | Status | |
|---|---|---|
| fennec | 32+ | --- |
People
(Reporter: ibarlow, Assigned: lucasr)
References
Details
Attachments
(2 files)
|
6.19 KB,
application/x-zip-compressed
|
Details | |
|
19.56 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
Our about:home placeholder thumbs are different from our "empty" thumbnails where we either don't yet have a page thumbnail or we lose it.
http://cl.ly/image/3d1v2p1N0l2X
It's pretty bad, and something we just keep forgetting to fix. My 2 minute fix idea is that we should use the same placeholder thumbnails everywhere. So take the one we use for about:home, and use that for missing thumbnails as well.
Anthony and I are going to revisit the look of that placeholder, will post new graphcis shortly.
|
Reporter | |
Comment 1•11 years ago
|
||
Updated tab thumbnail images attached. Screenshot for reference: http://cl.ly/image/46322q0C0g34
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → lucasr.at.mozilla
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8423798 -
Flags: review?(mark.finkle)
|
|
Reporter | |
Updated•11 years ago
|
tracking-fennec: --- → ?
|
||
Updated•11 years ago
|
tracking-fennec: ? → 32+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8423798 [details] [diff] [review]
Use same placeholder image on all tabs (r=mfinkle)
Redirecting review.
Attachment #8423798 -
Flags: review?(mark.finkle) → review?(margaret.leibovic)
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8423798 [details] [diff] [review]
Use same placeholder image on all tabs (r=mfinkle)
Review of attachment 8423798 [details] [diff] [review]:
-----------------------------------------------------------------
Nice.
Attachment #8423798 -
Flags: review?(margaret.leibovic) → review+
|
||
Comment 5•11 years ago
|
||
Can you make sure that the icon is vertically centered before landing? See the older bug 912512. :-)
Not sure if that was a code or an asset issue... Thanks!
|
|
Assignee | |
Comment 6•11 years ago
|
||
(In reply to Peter Retzer (:pretzer) from comment #5)
> Can you make sure that the icon is vertically centered before landing? See
> the older bug 912512. :-)
> Not sure if that was a code or an asset issue... Thanks!
Yeah, the new image looks vertically centered, thanks for pointing this out :-)
|
|
Assignee | |
Comment 7•11 years ago
|
||
|
||
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•