1010775 - Pass some small classes by value instead of const reference

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Jan de Mooij [:jandem]]

Classes like Register, Imm32 etc are sometimes passed by value and sometimes by const reference. It's very inconsistent, the code looks less cluttered if we pass by value and it's potentially more efficient.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Part 1 - Register

I verified these patches compile on x86 and ARM (simulator build).

It's just a search-and-replace + some minor style tweaks after that.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Part 2 - Imm32

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Part 3 - ImmWord

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Part 4 - ImmPtr

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Part 5 - ImmGCPtr and ImmMaybeNurseryPtr

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Part 6 - AbsoluteAddress and PatchedAbsoluteAddress

Comment 7

[Jan de Mooij [:jandem]]

Attachment: Part 7 - AsmJSAbsoluteAddress and AsmJSImmPtr

Comment 8

[Jan de Mooij [:jandem]]

Attachment: Part 8 - FloatRegister

Bug 991153 will change the FloatRegister implementation on ARM, but it will still fit in one word.

Comment 9

[Dan Gohman [:sunfish]]

Comment on attachment 8423076 [details] [diff] [review]
Part 1 - Register

Review of attachment 8423076 [details] [diff] [review]:
-----------------------------------------------------------------

Splendid.

Comment 10

[Jan de Mooij [:jandem]]

Thanks for the quick reviews!

https://hg.mozilla.org/integration/mozilla-inbound/rev/88201d0deed8
https://hg.mozilla.org/integration/mozilla-inbound/rev/516dd2e509ac
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c66e8cda11e
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6283c3df595
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a437dfb01bd
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f0918a55223
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bf09205a537
https://hg.mozilla.org/integration/mozilla-inbound/rev/f61c1fc785f5

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/88201d0deed8
https://hg.mozilla.org/mozilla-central/rev/516dd2e509ac
https://hg.mozilla.org/mozilla-central/rev/3c66e8cda11e
https://hg.mozilla.org/mozilla-central/rev/d6283c3df595
https://hg.mozilla.org/mozilla-central/rev/7a437dfb01bd
https://hg.mozilla.org/mozilla-central/rev/3f0918a55223
https://hg.mozilla.org/mozilla-central/rev/9bf09205a537
https://hg.mozilla.org/mozilla-central/rev/f61c1fc785f5