1011000 - Enable audio channel change Gaia UI Tests checking

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)

Description

[:gerard-majax]

Once bug 971554 and bug 1006356 are fixed, we will leverage the accessibility of SoundManager to make the |self.data_layer.wait_for_audio_channel_changed()| assertions useful in tests/python/gaia-ui-tests/gaiatest/tests/functional/dialer/test_dialer.py.

Comment 1

[:gerard-majax]

We can now work on this.

Comment 2

[Robert Chira [:RobertC]]

Alexandre, are you working on this or can it be re-assigned?

Comment 3

[:gerard-majax]

Sadly I'm stuck on other things right now, so yes it can be re-assigned :)

Comment 4

[Robert Chira [:RobertC]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24382

Alexandre, can you please take a quick look over the patch and see if the audio channels I am waiting for in the test are correct? The channels I added in the test are based on the current behavior.

Comment 5

[Florin Strugariu [:Bebe]]

Comment on attachment 8494502 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24382

The code looks OK 

R+ if Alexandre confirms that we use the correct channels

Comment 6

[:gerard-majax]

(In reply to Robert Chira [:RobertC] from comment #4)
> Created attachment 8494502 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24382
> 
> Alexandre, can you please take a quick look over the patch and see if the
> audio channels I am waiting for in the test are correct? The channels I
> added in the test are based on the current behavior.

I'm sorry, but it's been quite some time, I'm not peer for this, and I don't have much time to investigate this now, so I cannot really judge this.

Comment 7

[Florin Strugariu [:Bebe]]

Comment on attachment 8494502 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24382

Tony can you point us to the right person to give us feedback if we are verifying the correct audio channels in this tests

Comment 8

[Tony Chung [:tchung]]

Gregor, can you help assign a sysfe dev to assist QA in reviewing this test?  If this is not the right team, let me know who i can reach out to.   Thanks!

Comment 9

[Gregor Wagner [:gwagner]]

(In reply to Tony Chung [:tchung] from comment #8)
> Gregor, can you help assign a sysfe dev to assist QA in reviewing this test?
> If this is not the right team, let me know who i can reach out to.   Thanks!

Hm not sure who the right person is here. Baku, do you know this? Thinker, anyone from your team that can help out here?

Comment 10

[Andrea Marchesini [:baku]]

no, sorry.

Comment 11

[Zac C (:zac)]

Comment on attachment 8494502 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24382

r-, but a really good change to cut down on the excess code. but needs a refactor of the wait method , it's a good chance to improve data_layer class too.

Comment 12

[Robert Chira [:RobertC]]

Comment on attachment 8494502 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24382

I updated the PR, but there is still the problem if the channels we are asserting are correct.

Comment 13

[Florin Strugariu [:Bebe]]

Comment on attachment 8494502 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24382

Looks OK to me

About the channel asserting I think they are OK. I no dev is giving us a correct answer we can assume these are the correct channels

Comment 14

[Zac C (:zac)]

Comment on attachment 8494502 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24382

r+, works very nicely and real clean code.

I agree with bebe; if we change the channels then the test will fail so they must be the correct ones.

Comment 15

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/a1c64600bf41525a5cbde293dcfa50f8d6f24eb6

Thanks Robert!

Comment 16

[Robert Chira [:RobertC]]

Attachment: Uplift to v2.1

Comment 17

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8511938 [details] [review]
Uplift to v2.1

Tested and working on:
Gaia-Rev        c97463d61f45513a2123b19610386ddbfc916819
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/4f8c0c021128
Build-ID        20141027001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  39
FW-Date         Thu Oct 16 18:19:14 CST 2014
Bootloader      L1TC00011880

Comment 18

[Viorela Ioia [:viorela]]

Comment on attachment 8511938 [details] [review]
Uplift to v2.1

Merged on v2.1: https://github.com/mozilla-b2g/gaia/commit/7a80c906b9d27d7daef7423324a48f04939f0947