Closed Bug 1011001 Opened 11 years ago Closed 11 years ago

[basket] The optin option to subscribe API should require an API key

Categories

(www.mozilla.org :: Newsletters, defect)

Product:
www.mozilla.org
Component:
Newsletters
Version:
Production
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: pmac, Assigned: pmac)

References

Details

Attachments

(1 file)

pull request
41 bytes, text/x-github-pull-request
Details | Review 
Also it should work. The optin option is still there but it is no longer respected. We should add that function back.
Status: NEW → ASSIGNED
I'm also planning on not returning an error if optin=Y and no valid API key is found. For backward compatibility the request will just proceed normally as if optin=N.
Status: ASSIGNED → NEW
Attached file pull request — 

    
    

    
  
Commit pushed to master at https://github.com/mozilla/basket

https://github.com/mozilla/basket/commit/8eddf5946ec35d264ad67a3bcadc28b967a89ec2
Fix bug 1011001: Add support for optin param back to subscribe.

* Fix flake8 issue. Add flake8 config.
* Improve optin documentation in README and doc string.
* Also add some case-insensitivity tests.

    
  
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
    

    
  
Go-live-to-prod goal date: June 2

Currently on stage and ready to push to prod.

    
    

    
  
This is now live in prod!
Status: RESOLVED → VERIFIED

    
  
Blocks: 1054328

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: