1011019 - Clear all installtrigger callbacks on pagehide

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect)

Description

[:Gijs (he/him)]

Followup fodder from bug 926712:

(In reply to Dave Townsend [:mossop] from bug 926712 comment #21)
> @@ +44,5 @@
> > +  this._lastCallbackID = 0;
> > +  this._callbacks = new Map();
> > +  this.mm = Cc["@mozilla.org/childprocessmessagemanager;1"]
> > +            .getService(Ci.nsISyncMessageSender);
> > +  this.mm.addWeakMessageListener(MSG_INSTALL_CALLBACK, this);
> 
> I'm wondering what happens if the user navigates away from the page after
> the install starts but before the callback is called. GC might not have
> happened and so this mediator might still be alive which leaves us
> attempting to call a callback in a closed window. Hopefully that just fails
> but maybe it would be better to be safe and add a "pagehide" listener on the
> window and clear all the callbacks immediately. I wouldn't be surprised to
> learn that the current code has similar problems and it can certainly be a
> follow-up.

Comment 1

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.