1011116 - Project Editor: After folder is selected in file tree, the file does not get reselected when editor is focused

Status: VERIFIED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

STR:

1. Open AMv2 with Itchpad
2. Select a file (it's displayed in the editor)
3. Select a folder (your file is still from step 2 is still displayed)
4. Click into the file editor

ER:

I would expect the file to be re-selected in the tree, since I have now actively switched to the editor.  Otherwise, some random folder is selected, and there is no other display of the file name or path of what's shown in the editor.

AR:

The folder from step 3 remains selected.

Comment 1

[Brian Grinstead [:bgrins]]

(In reply to J. Ryan Stinnett [:jryans] from comment #0)

> I would expect the file to be re-selected in the tree, since I have now
> actively switched to the editor.  Otherwise, some random folder is selected,
> and there is no other display of the file name or path of what's shown in
> the editor.

I agree with your expected results, and think we should update it.  In general, there is also a case that the top status bar that was displaying the file name would be helpful (http://i.imgur.com/ibeuSqv.png vs http://i.imgur.com/tSRCq5p.png).  Paul wanted these removed to clean up the UI a bit (https://bugzilla.mozilla.org/show_bug.cgi?id=987089#c52), so they are hidden with CSS, but I think there is a case for leaving one or both.

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: editor-tree-selection.patch

Is this what you are thinking?

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8460993 [details] [diff] [review]
editor-tree-selection.patch

Review of attachment 8460993 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me, thanks!

Comment 4

[Heather Arthur [:harth]]

Comment on attachment 8460993 [details] [diff] [review]
editor-tree-selection.patch

Review of attachment 8460993 [details] [diff] [review]:
-----------------------------------------------------------------

I like the idea of some kind of file name display too.

Comment 5

[Brian Grinstead [:bgrins]]

> I like the idea of some kind of file name display too.

Yes, me too.  Paul originally voiced this concern about the 2 status bars taking up too much space in https://bugzilla.mozilla.org/show_bug.cgi?id=987089#c52.  If the concern is taking up too much space, maybe we could have a single status bar at the bottom that shows line:col / file name / syntax mode, etc.  Would have to play with it a bit but seems like it would be useful.

Comment 6

[Brian Grinstead [:bgrins]]

https://tbpl.mozilla.org/?tree=Try&rev=1552b6699419

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/3794fe9bfc26

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3794fe9bfc26

Comment 9

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed using latest Aurora 34.0a2 build (20141008004004) under Win 7 64-bit, Ubuntu 13.04 64-bit and Mac OSX 10.9.5.