1011257 - /builds/slave is read only for cltbld

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Rail Aliiev [:rail]]

manage_instance_storage.py mounts the instance storage as /builds/slave but doesn't care about the ownership of the directory. On regular instances this is fixed by puppet, but for AMIs supposed to work without puppet this doesn't work.

Comment 1

[Massimo Gervasini [:massimo]]

Attachment: [puppet] Bug 1011257 - builds slave is read only for cltbld.patch

Hi rail,

this patch updates permissions on /builds/slave and /build/ccache

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 8423857 [details] [diff] [review]
[puppet] Bug 1011257 - builds slave is read only for cltbld.patch

Review of attachment 8423857 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/aws/files/manage_instance_storage.py
@@ +539,5 @@
> +    os.chown(CCACHE_DIR, uid, gid)
> +
> +    # prepare bind shares
> +    remove_from_fstab(CCACHE_DIR)
> +    options = 'bind,noatime,uid=%s,gid=%s' % (FS_USER, FS_GROUP)

ext3 doesn't support uid=xxx, it won't help

chowning would be enough

Comment 3

[Massimo Gervasini [:massimo]]

Attachment: [puppet] Bug 1011257 - builds slave is read only for cltbld.patch

removed uid=cltbld,gid=cltbld options for ccache in /etc/fstab

Comment 4

[Massimo Gervasini [:massimo]]

Attachment: [puppet] Bug 1011257 - builds slave is read only for cltbld.patch

replaced os.chown() calls with run_cmd(['chown'm ...]), renamed SSD_METADATA_FILE to JACUZZI_METADATA_JSON

Comment 5

[Massimo Gervasini [:massimo]]

Attachment: [puppet] Bug 1011257 - builds slave is read only for cltbld.patch

moved chown/mount under try: in main()

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 8423934 [details] [diff] [review]
[puppet] Bug 1011257 - builds slave is read only for cltbld.patch

Review of attachment 8423934 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/aws/files/manage_instance_storage.py
@@ +535,4 @@
>      except OSError:
>          # mkdir failed, CCACHE_DIR not mounted
>          log.error('%s is not mounted', ccache_dst)
> +        return

return is redundant here. Can you remove it?