1011311 - Simplify availableFreeSpace check in ResolveFlexibleLengths() to assume its sign can't disagree with the type of flexing

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

Quoting & expanding on bug 1005660 comment 4:

I'm 95% sure that bug 1005660's fix will mean that we don't need the "if the sign of free space matches the type of flexing that we're doing" check[1] anymore. If the free space is nonzero, I think we can now assume that it *must* match our type of flexing. It can't be negative if we're growing, for example (or else we would have chosen to shrink instead of grow, or frozen a flex item that's trivially violating its max-width, up-front).

Filing this bug to cover this change.

[1] http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsFlexContainerFrame.cpp?rev=b37e7eabd9ef&mark=1705-1708#1705

Comment 1

[Daniel Holbert [:dholbert]]

Posted to www-style to propose that this change in the spec:
 http://lists.w3.org/Archives/Public/www-style/2014May/0169.html

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 3

[Daniel Holbert [:dholbert]]

Try run with patches for this bug & bug 1005660:
 https://tbpl.mozilla.org/?tree=Try&rev=b28d1276946c

Comment 4

[Mats Palmgren (inactive)]

Comment on attachment 8423542 [details] [diff] [review]
fix v1

r=mats

Comment 5

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6dc54be863ce

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6dc54be863ce