1011393 - Add support for 'csp' entries in Manifest Helper

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Vlatko Markovic]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140428193838

Steps to reproduce:

Try to install web application that have 'csp' field in its manifest.


Actual results:

The 'csp' field is not copied to the application object during the application installation so later it is not accessible on runtime.


Expected results:

Copy the 'csp' field value from the manifest to the app object and install the application with it. If later asked to get the applications' CSP we should get what we had in the manifest.

Comment 1

[Vlatko Markovic]

Manifest Helper object is missing support for csp field in the application manifest. As consequence when using a Helper object to handle an application manifest it is not possible to access the csp string when needed. The results is that app objects for installed apps never gets the csp field if present in the application manifest.

Comment 2

[Vlatko Markovic]

Attachment: Bug_1011393-Add-support-for-csp-entries-in-Manifest-Helper.patch

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 8423698 [details] [diff] [review]
Bug_1011393-Add-support-for-csp-entries-in-Manifest-Helper.patch

Review of attachment 8423698 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thanks!

Comment 4

[Carsten Book [:Tomcat]]

Hi,
could you provide a Try link. Suggestions for what to run if you haven't
yet can be found here:
https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices

Comment 5

[Vlatko Markovic]

(In reply to Carsten Book [:Tomcat] from comment #4)
> Hi,
> could you provide a Try link. Suggestions for what to run if you haven't
> yet can be found here:
> https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices

Hi,

I don't have the needed privileges to push commits to Try server.
Could you help out with that?

Comment 6

[Carsten Book [:Tomcat]]

Hi Vlatko,

for the try access please see http://www.mozilla.org/hacking/committer/ for how to file a bug etc 

If that Bug is filed someone need to vouch, that could be as example fabrice since he already reviewed your patch here, you can post this bug number also here

Comment 7

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/bdece75d7f5e

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bdece75d7f5e

Comment 9

[[:fabrice] Fabrice Desré]

Blocking a THA blocker.

Comment 10

[[:fabrice] Fabrice Desré]

 https://hg.mozilla.org/releases/mozilla-aurora/rev/df42b05782aa