1011470 - Remove panel picker logic

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[:Margaret Leibovic]

In bug 1009586, we're removing the "Add panel" item from the home panel settings, since it's confusing for users.

This leaves us with the question of whether or not we'll ever show the panel picker somewhere else. The panel picker currently displays panels that are registered, but not installed, on the user's home page. However, unless an add-on explicitly decides to do this, this list is empty, and a main part of the confusion from the "Add panel" item was that the user needed to actually have an add-on already installed to see something there.

I think we should just remove the panel picker logic for now, and we have hg/bugzilla history to turn to if we ever want to add it back if we ever want to build a way for users to add new panels from native UI (as opposed to just installing add-ons).

Comment 1

[:Margaret Leibovic]

I just want to double check with ibarlow about plowing ahead here. Are we okay with just removing the panel picker? This also means that we wouldn't finish bug 987869.

As we've discussed before, if we do have some sort of native UI for adding new panels, I think we'll need to re-think how it works (and maybe just make it display a set of promoted add-ons). That doesn't seem like a high priority at this point, so we could file new bugs for that if/when we decide to do it.

Comment 2

[Ian Barlow (:ibarlow)]

(In reply to :Margaret Leibovic from comment #1)
> I just want to double check with ibarlow about plowing ahead here. Are we
> okay with just removing the panel picker? This also means that we wouldn't
> finish bug 987869.

Yes, I am ok with this for now.

> As we've discussed before, if we do have some sort of native UI for adding
> new panels, I think we'll need to re-think how it works (and maybe just make
> it display a set of promoted add-ons). That doesn't seem like a high
> priority at this point, so we could file new bugs for that if/when we decide
> to do it.

Yeah, agreed. A lot of this assumed we would have tons of partners in place early on, but given that we don't, the picker model makes less sense now than it did. I've started sketching out some alternate ideas, will share them soonish

Comment 3

[:Margaret Leibovic]

Attachment: Remove panel picker logic

Some housekeeping.

Comment 4

[Chenxia Liu [:liuche]]

Comment on attachment 8473981 [details] [diff] [review]
Remove panel picker logic

Review of attachment 8473981 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/5cfdd17fdca9

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5cfdd17fdca9