1011510 - Codegen.py: Add EndGuard to enum generation

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jan Varga [:janv]]

Attachment: patch

We have this enum in webidl:
enum FileMode { "readonly", "readwrite" };

Codegen.py generates FileModeBinding.h with this content:
MOZ_BEGIN_ENUM_CLASS(FileMode, uint32_t)
  Readonly,
  Readwrite
MOZ_END_ENUM_CLASS(FileMode)

I would like to see:
MOZ_BEGIN_ENUM_CLASS(FileMode, uint32_t)
  Readonly,
  Readwrite,
  EndGuard
MOZ_END_ENUM_CLASS(FileMode)

So I can add a serialization helper for IPDL:
template <>
struct ParamTraits<mozilla::dom::FileMode> :
  public ContiguousEnumSerializer<
                          mozilla::dom::FileMode,
                          mozilla::dom::FileMode::Readonly,
                          mozilla::dom::FileMode::EndGuard>
{ };

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8423870 [details] [diff] [review]
patch

Please call it _EndGuard and add an assert in the codegen that none of the enum values collide with it.

Comment 2

[Jan Varga [:janv]]

Attachment: patch

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8424008 [details] [diff] [review]
patch

r=me if you make it 

  'Enum value "' + value + '" cannot be used because it collides with our internal EndGuard_ value.  Please rename our internal EndGuard_ to something else'

Comment 4

[Jan Varga [:janv]]

Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/d221383c1e8e

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d221383c1e8e