1011538 - Highlight JS errors in logs

Status: RESOLVED DUPLICATE of bug 920191

(Tree Management Graveyard :: TBPL, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

We highlight some errors found in log files, but not JS errors. I burnt a lot of time because I didn't notice a single "JavaScript Error" line. Would be nice if those were highlighted too.

Comment 1

[Ed Morley [:emorley]]

We'd need to make these fatal first before highlighting them, otherwise the excerpt on TBPL will reference many spammy errors, confusing someone looking at an unrelated failure (we've had issues with this before). Totally agree it would be good to highlight once that's done (and that making them fatal is desirable too).

See also bug 920191 - albeit, I think you're meaning errors that end up in the console, right?

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Ed Morley [:edmorley UTC+0] from comment #1)
> We'd need to make these fatal first before highlighting them, otherwise the
> excerpt on TBPL will reference many spammy errors, confusing someone looking
> at an unrelated failure (we've had issues with this before). Totally agree
> it would be good to highlight once that's done (and that making them fatal
> is desirable too).
> 
> See also bug 920191 - albeit, I think you're meaning errors that end up in
> the console, right?

Yup, they should be fatal too. And yes, I am talking about errors that go to the console.

Comment 3

[Ed Morley [:emorley]]

This needs to be fixed on the harness side - once bug 920191 is fixed the JS errors will automatically be highlighted due to the mozharness highlighting.