Closed Bug 1011541 Opened 8 years ago Closed 8 years ago

IonMonkey: Implement Div Recover Instruction

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: nbp, Assigned: sankha)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good first bug][mentor=nbp][lang=c++])

Attachments

(1 file, 2 obsolete files)

Implement RDiv in js/src/jit/Recover.cpp.
See Bug 1003801 comment 0 for explanation.
Attached patch patchv1 (obsolete) — Splinter Review
Attachment #8424470 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8424470 [details] [diff] [review]
patchv1

Review of attachment 8424470 [details] [diff] [review]:
-----------------------------------------------------------------

(Canceled review, fix RSub and this patch too before fixing other bugs)
Attachment #8424470 - Flags: review?(nicolas.b.pierron)
Attached patch patchv2 (obsolete) — Splinter Review
Attachment #8424470 - Attachment is obsolete: true
Attachment #8435784 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8435784 [details] [diff] [review]
patchv2

Review of attachment 8435784 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/MIR.h
@@ +4507,5 @@
>      TruncateKind operandTruncateKind(size_t index) const;
> +
> +    bool writeRecoverData(CompactBufferWriter &writer) const;
> +    bool canRecoverOnBailout() const {
> +        return specialization_ != MIRType_None;

Same as the RMul patch, follow the condition used in getAliasSet.
Attachment #8435784 - Flags: review?(nicolas.b.pierron) → review+
Attached patch patch v3Splinter Review
Putting the previous r+. Applies cleanly on the patch in bug 1011540.

tbpl: https://tbpl.mozilla.org/?tree=Try&rev=2ab9708a5f4f
Assignee: nobody → sankha93
Attachment #8435784 - Attachment is obsolete: true
Attachment #8436103 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4fa4ba576464
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.