1011541 - IonMonkey: Implement Div Recover Instruction

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Nicolas B. Pierron [:nbp | PTO until 11/11]]

Implement RDiv in js/src/jit/Recover.cpp.
See Bug 1003801 comment 0 for explanation.

Comment 1

[Sankha Narayan Guria [:sankha]]

Attachment: patchv1

Comment 2

[Nicolas B. Pierron [:nbp | PTO until 11/11]]

Comment on attachment 8424470 [details] [diff] [review]
patchv1

Review of attachment 8424470 [details] [diff] [review]:
-----------------------------------------------------------------

(Canceled review, fix RSub and this patch too before fixing other bugs)

Comment 3

[Sankha Narayan Guria [:sankha]]

Attachment: patchv2

Comment 4

[Nicolas B. Pierron [:nbp | PTO until 11/11]]

Comment on attachment 8435784 [details] [diff] [review]
patchv2

Review of attachment 8435784 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/MIR.h
@@ +4507,5 @@
>      TruncateKind operandTruncateKind(size_t index) const;
> +
> +    bool writeRecoverData(CompactBufferWriter &writer) const;
> +    bool canRecoverOnBailout() const {
> +        return specialization_ != MIRType_None;

Same as the RMul patch, follow the condition used in getAliasSet.

Comment 5

[Sankha Narayan Guria [:sankha]]

Attachment: patch v3

Putting the previous r+. Applies cleanly on the patch in bug 1011540.

tbpl: https://tbpl.mozilla.org/?tree=Try&rev=2ab9708a5f4f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4fa4ba576464

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4fa4ba576464