1011550 - include device in fota mar filenames

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

We did this already for OTAs, but not FOTAs.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: be less fussy about fota mar filename

There's a risk that we'd accidentally upload a full FOTA if we ever hit a case where we only generate it. AFAICT we only generate gecko+gaia FOTAs right now. We'd still be safe if we started generating full in addition to those, because query_marfile_path would throw an error about finding too many MARs.

I could add a "if full in filename" guard here, but that would prevent fotas from getting uploaded anywhere (including private places).

This would all be a lot easier and safer if we could put logic into the b2g build system, or pluck variables out of it. Without one of those we have to do crappy things like glob *.mar in the list of upload files.

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 8423926 [details] [diff] [review]
be less fussy about fota mar filename

I'd love if you could list the mars in the fatal().  Could be as verbose as

self.fatal("Found none or too many marfiles in %s, don't know what to do:\n%s" % (mardir, str(mars)), exit_code=1)

or something.  Because I'm lazy and don't want to have to ssh into the box.

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Aki Sasaki [:aki] from comment #2)
> Comment on attachment 8423926 [details] [diff] [review]
> be less fussy about fota mar filename
> 
> I'd love if you could list the mars in the fatal().  Could be as verbose as
> 
> self.fatal("Found none or too many marfiles in %s, don't know what to
> do:\n%s" % (mardir, str(mars)), exit_code=1)
> 
> or something.  Because I'm lazy and don't want to have to ssh into the box.

Good idea, I'll add that.

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 8423926 [details] [diff] [review]
be less fussy about fota mar filename

Landed w/ the fatal() message.

Comment 5

[Justin Wood (:Callek)]

Something here went live today

Comment 6

[[e-mail] (:bhearsum)]

Balrog submission failed for Hamachi and turned the build red:
05:28:36    FATAL - Couldn't find complete mar url in config or package_urls
05:28:36    FATAL - Running post_fatal callback...
05:28:36    FATAL - Exiting -1

Comment 7

[[e-mail] (:bhearsum)]

Failed similarly for Nexus 4, too.

Comment 8

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=40270807&tree=Mozilla-Central

Comment 9

[[e-mail] (:bhearsum)]

This actually might be an issue with the dated dirs patch, not this one...

Comment 10

[[e-mail] (:bhearsum)]

Indeed. This one is fine, the problem is actually in bug 1011486.

Comment 11

[[e-mail] (:bhearsum)]

Whoops, can't close this bug until I actually change the Gonk build system....

Comment 12

[[e-mail] (:bhearsum)]

Attachment: include device name in FOTA mars

This is pretty much the same as what we did for OTA mars. Build scripts have been updated to cope, so this should be able to be merged at any time.

Comment 13

[Dave Hylands [:dhylands]]

Comment on attachment 8427964 [details] [review]
include device name in FOTA mars

Looks good to me.

Comment 14

[[e-mail] (:bhearsum)]

Comment on attachment 8427964 [details] [review]
include device name in FOTA mars

I merged this: https://github.com/mozilla-b2g/gonk-misc/commit/87ee480405c4a109c01f68dd64de625f1ff819d9

Comment 15

[[e-mail] (:bhearsum)]

Attachment: update hamachi upload glob

So the MARs are being generated with the right names now, but this glob isn't catching them, so they're not being uploaded.

Comment 16

[[e-mail] (:bhearsum)]

Comment on attachment 8430032 [details] [diff] [review]
update hamachi upload glob

https://hg.mozilla.org/mozilla-central/rev/3a8486cf8b55

Comment 17

[[e-mail] (:bhearsum)]

All good now. We've got MARs like http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/2014-05-29-04-02-01-mozilla-central-hamachi/fota-hamachi-update.mar, and Balrog is pointing at them.

Comment 18

[[e-mail] (:bhearsum)]

Comment on attachment 8427964 [details] [review]
include device name in FOTA mars

Drivers, I'd like to backport both patches here to b2g30 so that we can use our new update server, which is more reliable and enables better compatibility with Socorro for crash reports.

There were no issues when this landed on master.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

I had to rebase the Gecko patch around the lack of bug 1010313 being on b2g30. Hopefully I did it right.

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/57eefb0a9267

v1.4: https://github.com/mozilla-b2g/gonk-misc/commit/954b721011e9952de902c88c318209eaaa356068