Closed
Bug 1011589
Opened 10 years ago
Closed 10 years ago
Use mocha.css directly instead of copying the CSS from mocha.css to test-agent.css
Categories
(Firefox OS Graveyard :: Gaia::TestAgent, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: julienw, Assigned: rickychien)
Details
Attachments
(3 files, 1 obsolete file)
See [1], it seems that at one point we copied mocha's css directly in the test-agent CSS. This would be a good idea to use mocha's css instead, and possibly only override it if necessary in test-agent.css. [1] https://github.com/mozilla-b2g/js-test-agent/blob/63266195932081af785d9fb4e455077cc2be44c3/test-agent.css#L204-L473
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → ricky060709
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•10 years ago
|
||
I think that we only need to patch the test agent app on Gaia.
Attachment #8431423 -
Flags: review?(felash)
|
Reporter | |
Comment 2•10 years ago
|
||
Comment on attachment 8431423 [details] [review] Gaia PR looks good, but you also need a patch for js-test-agent, because we're copying the test agent CSS in "make update-common". Also bug 874510 will copy it each time we run the test client/server so that we won't even have it checked in in git :)
Attachment #8431423 -
Flags: review?(felash) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8438880 [details] Js-test-agent PR >https://github.com/mozilla-b2g/js-test-agent/pull/80/files
Attachment #8438880 -
Attachment mime type: text/plain → text/x-github-pull-request
|
|
Assignee | |
Comment 6•10 years ago
|
||
Attachment #8438880 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•10 years ago
|
||
Passed on Travis: https://github.com/mozilla-b2g/gaia/pull/19812 https://github.com/mozilla-b2g/js-test-agent/pull/80 Passed on Try: https://tbpl.mozilla.org/?tree=Gaia-Try&rev=d65f097ca2b1
|
|
Assignee | |
Comment 8•10 years ago
|
||
Merged. https://github.com/mozilla-b2g/gaia/commit/fc2a908adabf98f12dd851fa3c9965f4e37e2da0 https://github.com/mozilla-b2g/js-test-agent/commit/20c367da3a56129517e033e3975a017ade4492f4 https://github.com/mozilla-b2g/gaia-node-modules/commit/ba0a62a3897ea80148bd120fe557dacd30d6ec3f
|
|
Assignee | |
Comment 9•10 years ago
|
||
Merged follow-up bug of updating gaia_node_modules.revision. https://github.com/mozilla-b2g/gaia/commit/856395fcb9451f7b36184be9d337d103be647564
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•