101166 - users seeing a bug via *_accessible bits should see group names

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect, P2)

Description

[Bradley Baetz (:bbaetz)]

Currently if a user isn't in a group for the bug, but is on the cc list, they
see the text: "But users in the roles selected below can always view this bug:"
without anything before it. If they are in one group, but not the one the bug is
restricted to, then it looks just like an unrestricted bug.

Instead, they should see either just the group name, or a disabled checkbox
field. (There is code in process_bug.cgi to stop users adding/removing a bug
from groups that they aren't in)

As well, we should consider only allowing the _accessible bits to be changed by
someone who is in all the groups in the bug's groupset. If we do this, then the
ui should be modified to only list those bits which are on, or just have
disabled checkboxes which are checked/unchecked as appropriate. The backend
would also have to be changed.

Comment 1

[Bradley Baetz (:bbaetz)]

OK, patch coming. I've decided to defer the who can change what policy issues
until later, if someone ever complains.

Note that this uses a disabled input attribute, which isn't supported by ns4,
hence the text. The backend won't allow it to be changed though, and there is no
warning/error. (because currently the form fields aren't there, so we always
readd the group bits so that anyone not in the group commenting on the bug
doesn't remove the setting)

Comment 2

[Bradley Baetz (:bbaetz)]

Attachment: patch

Comment 3

[Dave Miller [:justdave]]

Comment on attachment 55665 [details] [diff] [review]
patch

r= justdave
played with it on my local install, it works, and doesn't appear to break anything.

Comment 4

[Jacob Steenhagen]

Comment on attachment 55665 [details] [diff] [review]
patch

>Index: bug_form.pl
...
>       # For product groups, we only want to display the checkbox if either
>       # (1) The bit is already set, or
>       # (2) It's the group for this product.
>       # All other product groups will be skipped.  Non-product bug groups
>       # will still be displayed.
>-      if($ison || ($name eq $bug{'product'}) || (!defined $::proddesc{$name})) {
>+      if($ison || $ingroup || ($name eq $bug{'product'}) || (!defined $::proddesc{$name})) {

The change on this line (the addition of $ingroup) causes the group checkbox to show up
any time you are in that group, irregardless of if it's a product group for the product
the bug belongs to (causing groups for other products to start appearing where they didn't
before).  This is contrary to what the comment says (and what's prefered).

Comment 5

[Bradley Baetz (:bbaetz)]

Attachment: new patch

Comment 6

[Dave Miller [:justdave]]

Comment on attachment 56791 [details] [diff] [review]
new patch

r= justdave
I only had one product group on the install I played with it on the first time.
This one looks good.

Comment 7

[Jacob Steenhagen]

Comment on attachment 56791 [details] [diff] [review]
new patch

Much better :)
r=jake

Comment 8

[Bradley Baetz (:bbaetz)]

Fix checked in