1011668 - TypeError: not enough arguments for format string error trying to wrap a low-level crash (Crash Reporter)

Status: VERIFIED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Our automation Flame hit https://crash-stats.mozilla.com/report/index/64512080-78d8-4769-975d-0857f2140516 (bug 1010292), which triggered the modal Crash Reporter dialog.

Looks like Marionette didn't capture/wrap it properly, resulting in:

(log snip)
...
11:28:35   File "/var/jenkins/workspace/b2g.flame.mozilla-central.adhoc.test_settings_wifi/.env/local/lib/python2.7/site-packages/marionette_transport-0.1-py2.7.egg/marionette_transport/transport.py", line 94, in send
11:28:35     raise IOError("%s: %s" % (str(e)), self.connection_lost_msg)
11:28:35 TypeError: not enough arguments for format string

http://selenium.qa.mtv2.mozilla.com:8080/view/B2G%20Flame/job/b2g.flame.mozilla-central.adhoc.test_settings_wifi/26/console

Comment 1

[David Burns :automatedtester]

We need to fix http://dxr.mozilla.org/mozilla-central/source/testing/marionette/transport/marionette_transport/transport.py#96

Looks like brackets are not done properly only passing in one argument.

Comment 2

[Varun Raj]

Can i work on it?

Comment 3

[Varun Raj]

This is the correct code. Please tell me what steps to follow to get it integrated in the main repository.
raise IOError("%s: %s" % (str(e), self.connection_lost_msg) )

Comment 4

[Varun Raj]

Attachment: bug1011668.diff

Comment 5

[David Burns :automatedtester]

Comment on attachment 8426341 [details] [diff] [review]
bug1011668.diff

Looks good, pushing to try https://tbpl.mozilla.org/?tree=Try&rev=cbdb2222b55b

Comment 6

[Mike Hoye [:mhoye]]

Since Varun's provided a patch, I'm assigning to Varun.

Comment 7

[David Burns :automatedtester]

Landed in https://hg.mozilla.org/integration/mozilla-inbound/rev/f797fb250394

Varun, Thanks for the patch! The next step is that it will run through the Mozilla build and test infrastructure. If all is good it will be merged to Mozilla-Central and the bug will be closed.

If you are wanting to try another bug, we have a few in https://bugzilla.mozilla.org/buglist.cgi?cmdtype=runnamed&namedcmd=marionette-gfb&list_id=10277951 and I will be adding more soon!

Thanks again!

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f797fb250394

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Thx, I haven't seen this since; verified with:

sdonner-10779:B2G-flash-tool sdonner$ ./check_versions.sh 
Gaia      0f9f11d0a6dadb3ea27160204bbe911c1ad69a6f
Gecko     https://hg.mozilla.org/mozilla-central/rev/196d05832e12
BuildID   20140709040203
Version   33.0a1
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Moving bugs for Marionette client due to component changes.