1011693 - Store dollar index instead of jschar* in ReplaceData

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

We want this for both ASCII strings and nursery-allocated strings/chars.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Part 1 - rm ReplaceData::dollarEnd

dollarEnd is repstr->chars() + repstr->length(). There's no need to store it separately.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Part 2 - Refactor some loops

Rewrites two loops a bit to prepare for the next patch.

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Part 3 - Store dollar position as index instead of jschar*

s/ReplaceData::dollar/ReplaceData::dollarIndex.

Also removed the ENSURE() macro for error handling while I was there. if (!x) return false; is an extra line but it's much clearer.

Comment 4

[Terrence Cole [:terrence]]

Comment on attachment 8424129 [details] [diff] [review]
Part 1 - rm ReplaceData::dollarEnd

Review of attachment 8424129 [details] [diff] [review]:
-----------------------------------------------------------------

I had forgotten how horrific the existing code here is. r=me

Comment 5

[Terrence Cole [:terrence]]

Comment on attachment 8424132 [details] [diff] [review]
Part 2 - Refactor some loops

Review of attachment 8424132 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 6

[Terrence Cole [:terrence]]

Comment on attachment 8424134 [details] [diff] [review]
Part 3 - Store dollar position as index instead of jschar*

Review of attachment 8424134 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! r=me

Comment 7

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6d6c5381f95
https://hg.mozilla.org/integration/mozilla-inbound/rev/578778d7baca
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8edc293a081

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d6d6c5381f95
https://hg.mozilla.org/mozilla-central/rev/578778d7baca
https://hg.mozilla.org/mozilla-central/rev/e8edc293a081