1011739 - ThirdPartyUtil::GetBaseDomain should stop emitting confusing warnings.

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect, P5)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Ran across this when implementing cookie injection on an about: page for Loop.

ThirdPartyUtil::GetBaseDomain uses NS_ENSURE_TRUE to check whether something is a file: URI or not and return an appropriate nsresult:

http://dxr.mozilla.org/mozilla-central/source/content/base/src/ThirdPartyUtil.cpp?from=ThirdPartyUtil.cpp&case=true#284

Those semantics are fine and entirely intentional, but it also spews out a confusing (and ultimately useless) warning to the console in the failure case, wasting developer time tracking it down and creating more noise that makes it easier to overlook console errors that are actually important.

Comment 1

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 2

[s4k118]

Hi I'm newbie here, and would like to work on this bug. Is this still open now?

The link you put looks already expired. Is it same as here?
https://dxr.mozilla.org/mozilla-central/source/dom/base/ThirdPartyUtil.cpp#403

Also, this bug can be solved by just removing this line NS_ENSURE_SUCCESS()?

Comment 3

[s4k118]

Attachment: Bug 1011739 - Remove NS_ENSURE_SUCCESS()

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Sorry for not getting back to you sooner on this! Looks like :baku proposed a slightly different fix to the attached patch in phabricator, so updating to that and requesting review from him is probably the right next step.

Comment 5

[Dylan]

Attachment: Bug 1011739 - Removed NS_ENSURE_SUCCESS to avoid showing confusing warning messages. r=baku

Comment 6

[Dylan]

Attachment: Bug 1011739 - Removed NS_ENSURE_SUCCESS to avoid showing confusing warning messages. r=baku

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7d57f6f297d
Removed NS_ENSURE_SUCCESS to avoid showing confusing warning messages. r=valentin

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c7d57f6f297d