1011760 - Debugging evalled content scripts

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Jared Jacobs]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.137 Safari/537.36

Steps to reproduce:

Use a PageMod in an addon. Use window.eval to add more scripts (containing //# sourceURL annotations) to the PageMod. Open the Addon Debugger.


Actual results:

Only the scripts that were initially included in the PageMod appear in the Addon Debugger.


Expected results:

The scripts dynamically added to the PageMod using window.eval should also appear in the Addon Debugger.

Note: I will gladly switch away from using window.eval if there is some other recommended method of dynamically adding scripts packaged with the addon to a PageMod.

Note: Issue 833744 is related, but I’m filing this issue separately because it’s specifically for addon content scripts injected on demand, a use case for which there are no known alternatives to window.eval. (My extension has a PageMod that begins as one small script file but, based on user behavior, can grow to include upwards of 50 script files.)

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

jmjacobs: can you attach a reduced test case? Thanks!

Comment 2

[Jared Jacobs]

Attachment: content_script_eval.zip

Sure. Here’s a small toy extension that demonstrates the issue.

Comment 3

[Jared Jacobs]

Comment on attachment 8437058 [details]
content_script_eval.zip

Whoops, I forgot to include the //# sourceURL annotations.

Comment 4

[Jared Jacobs]

Attachment: content_script_eval.zip

This version has the //# sourceURL annotations.

Note that button.js can be opened in the debugger, since it’s part of the initial PageMod declaration, but jquery.js and ui.js cannot because they are injected later using window.eval (after you click the button).

Comment 5

[Eddy Bruel [:ejpbruel]]

It seems to me as if this should be fixed automatically once bug 865313 lands.

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

Closing.  PageMod is no longer supported and bug 865313 has landed so this should be done.