Closed Bug 1011806 Opened 6 years ago Closed 6 years ago

Stop loading user-agent/user style sheets for SVG-as-an-image (leave svg.css, html.css and xul.css loading on-demand)

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: jwatt, Assigned: jwatt)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [MemShrink:P2])

Attachments

(1 file, 2 obsolete files)

With the testcase from bug 999931 on the keon, skipping the loading of all UA style sheets other than svg.css reduces the image memory by 75%.

This builds on bug 1008455 and bug 1011802 (which provide wins for most document types) by being much more aggressive for SVG-as-an-image only.
When somebody new starts looking for ways to reduce memory usage in parts of the browser that haven't been looked at closely, it's great to see what they find :)
Well let's see if this flies. ;)
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → jwatt
Attachment #8426356 - Flags: review?(bzbarsky)
Attached patch patch (obsolete) — Splinter Review
Attachment #8426356 - Attachment is obsolete: true
Attachment #8426356 - Flags: review?(bzbarsky)
Attachment #8426359 - Flags: review?(bzbarsky)
Summary: Preload only the svg.css user-agent style sheet for SVG-as-an-image → Stop loading user-agent/user style sheets for SVG-as-an-image (leave svg.css, html.css and xul.css loading on-demand)
Depends on: 1013936
No longer depends on: 1011802
Comment on attachment 8426359 [details] [diff] [review]
patch

r=me as long as you don't land this before its dependencies.  ;)
Attachment #8426359 - Flags: review?(bzbarsky) → review+
Comment on attachment 8426359 [details] [diff] [review]
patch

Actually, r- per IRC discussion since the prereqs don't do what I thought they did.
Attachment #8426359 - Flags: review+ → review-
Attached patch patchSplinter Review
With the changes made to the part 2 patch in bug 1013936 I think this is okay now.
Attachment #8426359 - Attachment is obsolete: true
Attachment #8426608 - Flags: review?(bzbarsky)
Comment on attachment 8426608 [details] [diff] [review]
patch

r=me
Attachment #8426608 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d3d1e8d9a6e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.