1011815 - Eliminate unnecessary uses of nsISupports in WebIDL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We have a bunch of things that are "nsISupports" but could be more reasonable types.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Replace nsISupports with DOMRequest in MozIcc.webidl

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Make DOMRequest.error be a DOMError

Comment 3

[Edgar Chen [:edgar]]

Comment on attachment 8424289 [details] [diff] [review]
part 1.  Replace nsISupports with DOMRequest in MozIcc.webidl

Review of attachment 8424289 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :)

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8424290 [details] [diff] [review]
part 2.  Make DOMRequest.error be a DOMError

I wonder if some code passes non-DOMError as error. Couldn't find any such case.

Comment 5

[Boris Zbarsky [:bzbarsky]]

   https://hg.mozilla.org/integration/mozilla-inbound/rev/3a609fa17172
   https://hg.mozilla.org/integration/mozilla-inbound/rev/f654c8eba42e

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3a609fa17172
https://hg.mozilla.org/mozilla-central/rev/f654c8eba42e