Closed Bug 1011815 Opened 6 years ago Closed 6 years ago

Eliminate unnecessary uses of nsISupports in WebIDL

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(2 files)

We have a bunch of things that are "nsISupports" but could be more reasonable types.
Whiteboard: [need review]
Comment on attachment 8424289 [details] [diff] [review]
part 1.  Replace nsISupports with DOMRequest in MozIcc.webidl

Review of attachment 8424289 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :)
Attachment #8424289 - Flags: review?(echen) → review+
Attachment #8424289 - Flags: review?(bugs) → review+
Attachment #8424290 - Flags: review?(bugs) → review+
Comment on attachment 8424290 [details] [diff] [review]
part 2.  Make DOMRequest.error be a DOMError

I wonder if some code passes non-DOMError as error. Couldn't find any such case.
https://hg.mozilla.org/mozilla-central/rev/3a609fa17172
https://hg.mozilla.org/mozilla-central/rev/f654c8eba42e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.