Closed
Bug 1011958
Opened 10 years ago
Closed 10 years ago
ICS build bustage in out/host/linux-x86/obj/EXECUTABLES/triangleCM_intermediates/triangleCM
Categories
(Firefox OS Graveyard :: GonkIntegration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philor, Assigned: pmoore)
Details
Attachments
(1 file)
960 bytes,
patch
|
emorley
:
review+
|
Details | Diff | Splinter Review |
From whatever commit somewhere else wound up producing https://hg.mozilla.org/integration/b2g-inbound/rev/ab8927e5c996, https://tbpl.mozilla.org/php/getParsedLog.php?id=39870891&tree=B2g-Inbound 01:15:27 INFO - host Executable: triangleCM (out/host/linux-x86/obj/EXECUTABLES/triangleCM_intermediates/triangleCM) 01:15:27 INFO - g++: out/host/linux-x86/obj/STATIC_LIBRARIES/libSDL_intermediates/libSDL.a: No such file or directory 01:15:27 INFO - g++: out/host/linux-x86/obj/STATIC_LIBRARIES/libSDLmain_intermediates/libSDLmain.a: No such file or directory 01:15:27 INFO - make: *** [out/host/linux-x86/obj/EXECUTABLES/triangleCM_intermediates/triangleCM] Error 1 01:15:27 INFO - make: *** Waiting for unfinished jobs.... 01:15:27 INFO - host Executable: triangleV2 (out/host/linux-x86/obj/EXECUTABLES/triangleV2_intermediates/triangleV2) 01:15:27 INFO - g++: out/host/linux-x86/obj/STATIC_LIBRARIES/libSDL_intermediates/libSDL.a: No such file or directory 01:15:27 INFO - g++: out/host/linux-x86/obj/STATIC_LIBRARIES/libSDLmain_intermediates/libSDLmain.a: No such file or directory 01:15:27 INFO - make: *** [out/host/linux-x86/obj/EXECUTABLES/triangleV2_intermediates/triangleV2] Error 1 which means that b2g-inbound is closed.
Comment 1•10 years ago
|
||
i guess this change was made here http://git.mozilla.org/?p=external/caf/platform/prebuilts/tools.git;a=summary but no idea how get the commit out of this
Comment 2•10 years ago
|
||
The repo log is at http://git.mozilla.org/?p=external/caf/platform/prebuilts/tools.git;a=log;h=refs/heads/aosp-new/master aka something broke it upstream from us. As a short-term fix, we could pin the revision at acba00cdb4596c6dcb61ed06f14cf4ec89623539 instead of following the aosp-new branch. That'd be at https://github.com/mozilla-b2g/b2g-manifest/blob/master/emulator.xml#L112 I think.
Comment 3•10 years ago
|
||
Relevant lines from the log (beware parallel make!): 01:15:05 INFO - host Prebuilt: libSDL (out/host/linux-x86/obj/STATIC_LIBRARIES/libSDL_intermediates/libSDL.a) 01:15:05 INFO - host Prebuilt: libSDLmain (out/host/linux-x86/obj/STATIC_LIBRARIES/libSDLmain_intermediates/libSDLmain.a) 01:15:05 INFO - host Prebuilt: lib64SDL (out/host/linux-x86/obj/STATIC_LIBRARIES/lib64SDL_intermediates/lib64SDL.a) 01:15:05 INFO - acp: omitting directory 'prebuilts/tools/linux-x86/sdl/libs' 01:15:05 INFO - acp: omitting directory 'prebuilts/tools/linux-x86/sdl/libs' 01:15:05 INFO - host Prebuilt: lib64SDLmain (out/host/linux-x86/obj/STATIC_LIBRARIES/lib64SDLmain_intermediates/lib64SDLmain.a) 01:15:27 INFO - host Executable: triangleCM (out/host/linux-x86/obj/EXECUTABLES/triangleCM_intermediates/triangleCM) 01:15:27 INFO - g++: out/host/linux-x86/obj/STATIC_LIBRARIES/libSDL_intermediates/libSDL.a: No such file or directory 01:15:27 INFO - g++: out/host/linux-x86/obj/STATIC_LIBRARIES/libSDLmain_intermediates/libSDLmain.a: No such file or directory 01:15:27 INFO - make: *** [out/host/linux-x86/obj/EXECUTABLES/triangleCM_intermediates/triangleCM] Error 1 01:15:27 INFO - make: *** Waiting for unfinished jobs.... 01:15:27 INFO - host Executable: triangleV2 (out/host/linux-x86/obj/EXECUTABLES/triangleV2_intermediates/triangleV2) 01:15:27 INFO - g++: out/host/linux-x86/obj/STATIC_LIBRARIES/libSDL_intermediates/libSDL.a: No such file or directory 01:15:27 INFO - g++: out/host/linux-x86/obj/STATIC_LIBRARIES/libSDLmain_intermediates/libSDLmain.a: No such file or directory 01:15:27 INFO - make: *** [out/host/linux-x86/obj/EXECUTABLES/triangleV2_intermediates/triangleV2] Error 1 The actual code change appears to be: http://git.mozilla.org/?p=external/caf/platform/prebuilts/tools.git;a=commitdiff;h=aa5300cac014a5b0bab310c1ac2ebf216956dd60 while 7c954195f043a1a... is just a merge of that to aosp-new/master. Might just need a clobber ? Trying that.
Comment 5•10 years ago
|
||
note, its not b2g-inbound alone - also Mozilla-B2g30-v1.4 etc are affected so all b2g-i trees are closed at the moment
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Nick Thomas [:nthomas] from comment #2) > The repo log is at > > http://git.mozilla.org/?p=external/caf/platform/prebuilts/tools.git;a=log; > h=refs/heads/aosp-new/master > aka something broke it upstream from us. > > As a short-term fix, we could pin the revision at > acba00cdb4596c6dcb61ed06f14cf4ec89623539 instead of following the aosp-new > branch. That'd be at > https://github.com/mozilla-b2g/b2g-manifest/blob/master/emulator.xml#L112 > I think. I'll see if I can pin it in the manifest file...
Comment 8•10 years ago
|
||
Comment on attachment 8424687 [details] [diff] [review] bug1011958_b2g-manifest.patch Review of attachment 8424687 [details] [diff] [review]: ----------------------------------------------------------------- lgtm :-)
Attachment #8424687 -
Flags: review?(emorley) → review+
Comment 9•10 years ago
|
||
Committed to: * master: https://github.com/mozilla-b2g/b2g-manifest/commit/406b0c54c30356b28dfa36699e71145ad1239d6b * v1.4: https://github.com/mozilla-b2g/b2g-manifest/commit/95741100afff8d7115dd2483ea361ae3dc070c1c * v1.3: https://github.com/mozilla-b2g/b2g-manifest/commit/ba30cc6e13dcd0cd1496ebe50f40689abe338d16 * v1.3t: https://github.com/mozilla-b2g/b2g-manifest/commit/187cc3a6a9d49f96d0ac88399a8ac551007cc962 * v1.2: https://github.com/mozilla-b2g/b2g-manifest/commit/b196637be6adf3d86e2cbe72cff26c5a842f0925 * v1.2f: https://github.com/mozilla-b2g/b2g-manifest/commit/184cf0dfcb15346ce31148ddff8d245ad58483e3
Assignee | ||
Comment 10•10 years ago
|
||
After this occurred, we had a vidyo meeting (edmorley, Tomcat, pmoore) where we tracked the following issues in an etherpad, that we all believe need attention: https://releng.etherpad.mozilla.org/248 We decided it would be beneficial to meet with B2G dev to discuss these items. I will follow up with catlee from releng side. Pete
Flags: needinfo?(catlee)
Comment 11•10 years ago
|
||
From irc, email, etc. I think the consensus is that we should be pinning the manifest in b2g-manifests to the previously green revision for repositories we can't back out of. Bugs should be filed against B2G somewhere so we have some chance of un-pinning them later.
Flags: needinfo?(catlee)
Updated•10 years ago
|
Flags: needinfo?(mwu)
Assignee | ||
Comment 12•10 years ago
|
||
Is this bug now obsolete? AFAIK we bump to latest version, but sheriffs can pin if a downstream fails - but I don't think we have a generic way to find last green revision of an external repo (I don't think we e.g. monitor travis results of external repos). However maybe this bug was written at a time when b2g bumper wasn't freezing versions of external repos, so maybe it is no longer required.
Flags: needinfo?(emorley)
Comment 13•10 years ago
|
||
(In reply to Pete Moore [:pete][:pmoore] from comment #12) > Is this bug now obsolete? AFAIK we bump to latest version, but sheriffs can > pin if a downstream fails - but I don't think we have a generic way to find > last green revision of an external repo (I don't think we e.g. monitor > travis results of external repos). However maybe this bug was written at a > time when b2g bumper wasn't freezing versions of external repos, so maybe it > is no longer required. This bug is about one particular instance of breakage, rather than the bigger problem of not pinning. The latter is bug 1028111 (trunk) and bug 910745 (release branches). The manifests are still pinned (https://github.com/mozilla-b2g/b2g-manifest/blob/master/emulator.xml#L112) so the root cause behind this presumably still exists, and should someone in the future ever need to pin to a newer revision they'll need to fix it. However let's just call this bug fixed since the immediate breakage is resolved - they can always use git blame to find this bug if wondering why it was pinned.
Assignee: nobody → pmoore
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(emorley)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•