1012361 - simple-prefs tests don't cleanup after themselves

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Tomislav Jovanovic :zombie]

one native-options test fails because simple-prefs tests run before it on linux (and only on linux).  easy to change the pref name to avoid the conflict, but fixing this would probably be more "correct".

Comment 1

[Tomislav Jovanovic :zombie]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1492

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/08842b8d81cfd063bb46fb67d556b820c1a12df3
bug 1012361 - simple-prefs test cleanup

https://github.com/mozilla/addon-sdk/commit/d8f07dbd2464ae37cc8919abc0d9f627852ee391
Merge pull request #1492 from zombie/1012361-sp-test-clean

bug 1012361 - simple-prefs test cleanup, r=test-only

Comment 3

[Tomislav Jovanovic :zombie]

Comment on attachment 8424444 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1492

Erik, i didn't want to revert again, and also didn't want to leave half the tree orange, so per Wes's advice, i pushed this with r=test-only.

can you please review it now, and tell me if i did it right? ;)