1012507 - Perma failing test, month view #months-day-view scroll

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Kevin Grandon :kgrandon]

Two calendar tests started failing today for some reason:

 1) month view #months-day-view scroll:

Error: timeout exceeded!

at Object.Client.waitForSync (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:682:16)

at Object.Client.waitFor (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:650:60)

at Object.View.waitForDisplay (/home/travis/build/mozilla-b2g/gaia/apps/calendar/test/marionette/lib/views/view.js:43:24)

at Object.Calendar.createEvent (/home/travis/build/mozilla-b2g/gaia/apps/calendar/test/marionette/lib/calendar.js:217:15)

at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/apps/calendar/test/marionette/month_view_test.js:18:11)

at callFn (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:223:21)

at Test.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:216:7)

at Runner.runTest (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:374:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:452:12

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:299:14)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:309:7

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:247:23)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:271:7

at done (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:185:5)

at callFn (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:228:7)

at Hook.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:216:7)

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:259:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:271:7

at done (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:185:5)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:199:9

at Object.executeHook (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:369:18)

at process._tickCallback (node.js:415:13)

2) month view should show event dots:

Error: timeout exceeded!

at Object.Client.waitForSync (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:682:16)

at Object.Client.waitFor (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:650:60)

at Object.View.waitForDisplay (/home/travis/build/mozilla-b2g/gaia/apps/calendar/test/marionette/lib/views/view.js:43:24)

at Object.Calendar.createEvent (/home/travis/build/mozilla-b2g/gaia/apps/calendar/test/marionette/lib/calendar.js:217:15)

at createEvent (/home/travis/build/mozilla-b2g/gaia/apps/calendar/test/marionette/month_view_test.js:103:11)

at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/apps/calendar/test/marionette/month_view_test.js:122:5)

at callFn (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:223:21)

at Test.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:216:7)

at Runner.runTest (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:374:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:452:12

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:299:14)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:309:7

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:247:23)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:271:7

at done (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:185:5)

at callFn (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:228:7)

at Hook.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:216:7)

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:259:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:271:7

at done (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:185:5)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:199:9

at Object.executeHook (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:369:18)

at process._tickCallback (node.js:415:13)

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Screenshot at point of failure

Comment 3

[Kevin Grandon :kgrandon]

TBPL is currently closed so I am not sure if this is a gecko regression or what. Disabling from travis for the time being: https://github.com/mozilla-b2g/gaia/commit/cde26dc0df48b4d8f0a31e9a0bdfd7ebbec601c2

Comment 4

[Evan Tseng [:evanxd]]

Could the apps/calendar/test/marionette/month_view_test.js test could work on TBPL?

Comment 5

[Kevin Grandon :kgrandon]

(In reply to Evan Tseng [:evanxd][:愛聞插低] from comment #4)
> Could the apps/calendar/test/marionette/month_view_test.js test could work
> on TBPL?

We will find out soon, the tree has been closed until now due to some build bustage.

Comment 6

[Miller Medeiros [:millermedeiros]]

I found out the reason why this test fails.. It's because builds executed close to 1am and the created events had the default reminder (5 minutes before event), so after the notification showed up it covered the "add event" button and only created the first 2 events..

the timeout happened at (/home/travis/build/mozilla-b2g/gaia/apps/calendar/test/marionette/lib/calendar.js:217:15) which is `editEvent.waitForDisplay();`

I figured it out by going thru the build history and checking the timestamp, the screenshot was also helpful since it showed only 2 "busy dots" when it should display 3 (since we create 5 events).

passing `reminders: []` to the `createEvent` call or making no reminders the default, would solve this problem. - I'll to make "no reminders" the default since this kind of error is hard to catch locally and too easy to introduce, it's a time bomb waiting to happen.

Comment 7

[Kevin Grandon :kgrandon]

Oh wow, nice find Miller. Thanks for investigating!

Comment 8

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19396

Comment 9

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8425024 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19396

r=me thanks Miller for investigating

Comment 10

[Miller Medeiros [:millermedeiros]]

re-enabled the tests! https://github.com/mozilla-b2g/gaia/commit/ea7ef11479a21c4a23ce9f96a3c54b165d605f6f

Comment 11

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.