Closed Bug 1012621 Opened 6 years ago Closed 6 years ago

[B2G][SMS/MMS] Re-Layout Test Folders in MobileMessage

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(tracking-b2g:backlog)

RESOLVED FIXED
2.0 S3 (6june)
tracking-b2g backlog

People

(Reporter: bevis, Assigned: bevis)

References

Details

(Whiteboard: [p=2])

Attachments

(2 files, 3 obsolete files)

Currently, both test cases of mochitest/xpcshell are mixed in dom/mobilemessage/tests directory.

Fire this bug to re-layout test cases of Marionette/Mochitest/XpcShell into sub-directories of dom/mobilemessage/tests/ as followed:
dom/mobilemessage/tests/
├── marionette/
├── mochitest/
├── xpcshell/
└── moz.build
Depends on: 824717
Whiteboard: [p=2]
Target Milestone: --- → 2.0 S3 (6june)
Target Milestone: 2.0 S3 (6june) → ---
Target Milestone: --- → 2.0 S3 (6june)
Move mochitest related files into test/mochitest sub-folder.
Attachment #8425296 - Attachment is obsolete: true
Attachment #8431278 - Flags: review?(vyang)
Move xpcshell related files into test/xpcshell sub-folder.
Attachment #8431279 - Flags: review?(vyang)
Update try server result:
https://tbpl.mozilla.org/?tree=Try&rev=0df6e9913cf2

Marionette is passed in:
B2G ICS Emulator Opt Mnw

Xpcshell is passed in the following platform:
Android 2.3 Opt        X1
Android 4.0 Opt        X
B2G ICS Emulator Opt   X
B2G ICS Emulator Debug X

Mochitest is passed in the following platform:
Android 2.3 Opt           M(8)
Android 4.0 Opt           M(6)
Android 4.0 Debug         M(6)
B2G Desktop Linux Opt     M(1)
B2G Desktop Linux x64 Opt M(1)
B2G ICS Emulator Opt      M(7)
B2G ICS Emulator Debug    M(10)
Comment on attachment 8431278 [details] [diff] [review]
Patch Part 1 v1: Move mochitest related files into test/mochitest sub-folder.

Review of attachment 8431278 [details] [diff] [review]:
-----------------------------------------------------------------

Please use `hg mv` to generate this patch again.  It will minimize the patch even more while keeping rename informations.  Thank you.
Attachment #8431278 - Flags: review?(vyang) → feedback+
Comment on attachment 8431279 [details] [diff] [review]
Patch Part 2 v1: Move xpcshell related files into test/xpcshell sub-folder.

Review of attachment 8431279 [details] [diff] [review]:
-----------------------------------------------------------------

ditto.
Attachment #8431279 - Flags: review?(vyang) → feedback+
blocking-b2g: --- → backlog
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #5)
> Comment on attachment 8431278 [details] [diff] [review]
> Patch Part 1 v1: Move mochitest related files into test/mochitest sub-folder.
> 
> Review of attachment 8431278 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please use `hg mv` to generate this patch again.  It will minimize the patch
> even more while keeping rename informations.  Thank you.

Thanks! I'll re-create the patch with this command. :)
re-create patch with `hg mv`.
Attachment #8431278 - Attachment is obsolete: true
Attachment #8433789 - Flags: review?(vyang)
Recreate patch with `hg mv`
Attachment #8431279 - Attachment is obsolete: true
Attachment #8433790 - Flags: review?(vyang)
Comment on attachment 8433789 [details] [diff] [review]
Patch Part 1 v2: Move mochitest related files into test/mochitest sub-folder.

Review of attachment 8433789 [details] [diff] [review]:
-----------------------------------------------------------------

Hi, we need a build peer's review because this touches a moz.build file.  Thanks in advance.
Attachment #8433789 - Flags: review?(vyang)
Attachment #8433789 - Flags: review?(khuey)
Attachment #8433789 - Flags: review+
Attachment #8433790 - Flags: review?(vyang)
Attachment #8433790 - Flags: review?(khuey)
Attachment #8433790 - Flags: review+
Update try server result:
https://tbpl.mozilla.org/?tree=Try&rev=0b7294496f16

Marionette is passed in:
B2G ICS Emulator Opt Mnw

Xpcshell is passed in the following platform:
Android 2.3 Opt        X1
Android 4.0 Opt        X
B2G ICS Emulator Opt   X
B2G ICS Emulator Debug X

Mochitest is passed in the following platform:
Android 2.3 Opt           M(6)
B2G Desktop Linux Opt     M(1)
B2G Desktop Linux x64 Opt M(1)
B2G ICS Emulator Opt      M(7)
B2G ICS Emulator Debug    M(10)
Thanks you both for the review!
Keywords: checkin-needed
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.