1012621 - [B2G][SMS/MMS] Re-Layout Test Folders in MobileMessage

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

Currently, both test cases of mochitest/xpcshell are mixed in dom/mobilemessage/tests directory.

Fire this bug to re-layout test cases of Marionette/Mochitest/XpcShell into sub-directories of dom/mobilemessage/tests/ as followed:
dom/mobilemessage/tests/
├── marionette/
├── mochitest/
├── xpcshell/
└── moz.build

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: WIP: Separate Marionette/Mochitest/XpcShell Testcases into different folders.

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 1 v1: Move mochitest related files into test/mochitest sub-folder.

Move mochitest related files into test/mochitest sub-folder.

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 2 v1: Move xpcshell related files into test/xpcshell sub-folder.

Move xpcshell related files into test/xpcshell sub-folder.

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

Update try server result:
https://tbpl.mozilla.org/?tree=Try&rev=0df6e9913cf2

Marionette is passed in:
B2G ICS Emulator Opt Mnw

Xpcshell is passed in the following platform:
Android 2.3 Opt        X1
Android 4.0 Opt        X
B2G ICS Emulator Opt   X
B2G ICS Emulator Debug X

Mochitest is passed in the following platform:
Android 2.3 Opt           M(8)
Android 4.0 Opt           M(6)
Android 4.0 Debug         M(6)
B2G Desktop Linux Opt     M(1)
B2G Desktop Linux x64 Opt M(1)
B2G ICS Emulator Opt      M(7)
B2G ICS Emulator Debug    M(10)

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8431278 [details] [diff] [review]
Patch Part 1 v1: Move mochitest related files into test/mochitest sub-folder.

Review of attachment 8431278 [details] [diff] [review]:
-----------------------------------------------------------------

Please use `hg mv` to generate this patch again.  It will minimize the patch even more while keeping rename informations.  Thank you.

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8431279 [details] [diff] [review]
Patch Part 2 v1: Move xpcshell related files into test/xpcshell sub-folder.

Review of attachment 8431279 [details] [diff] [review]:
-----------------------------------------------------------------

ditto.

Comment 7

[Bevis Tseng[:bevis][:btseng](Exited)]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #5)
> Comment on attachment 8431278 [details] [diff] [review]
> Patch Part 1 v1: Move mochitest related files into test/mochitest sub-folder.
> 
> Review of attachment 8431278 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please use `hg mv` to generate this patch again.  It will minimize the patch
> even more while keeping rename informations.  Thank you.

Thanks! I'll re-create the patch with this command. :)

Comment 8

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 1 v2: Move mochitest related files into test/mochitest sub-folder.

re-create patch with `hg mv`.

Comment 9

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 2 v2: Move xpcshell related files into test/xpcshell sub-folder.

Recreate patch with `hg mv`

Comment 10

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8433789 [details] [diff] [review]
Patch Part 1 v2: Move mochitest related files into test/mochitest sub-folder.

Review of attachment 8433789 [details] [diff] [review]:
-----------------------------------------------------------------

Hi, we need a build peer's review because this touches a moz.build file.  Thanks in advance.

Comment 11

[Bevis Tseng[:bevis][:btseng](Exited)]

Update try server result:
https://tbpl.mozilla.org/?tree=Try&rev=0b7294496f16

Marionette is passed in:
B2G ICS Emulator Opt Mnw

Xpcshell is passed in the following platform:
Android 2.3 Opt        X1
Android 4.0 Opt        X
B2G ICS Emulator Opt   X
B2G ICS Emulator Debug X

Mochitest is passed in the following platform:
Android 2.3 Opt           M(6)
B2G Desktop Linux Opt     M(1)
B2G Desktop Linux x64 Opt M(1)
B2G ICS Emulator Opt      M(7)
B2G ICS Emulator Debug    M(10)

Comment 12

[Bevis Tseng[:bevis][:btseng](Exited)]

Thanks you both for the review!

Comment 13

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/e885df692af3
https://hg.mozilla.org/integration/b2g-inbound/rev/dfeac9b450c2

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e885df692af3
https://hg.mozilla.org/mozilla-central/rev/dfeac9b450c2