1012651 - [Contacts] Remove inline style for CSP compliance

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[:gerard-majax]

Confere bug 968907 and bug 858787. We need to remove all CSS inline usage in certified apps.

https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/elements/form.html#L111

Comment 1

[Fernando Campo (:fcampo)]

Attachment: Link to PR - https://github.com/mozilla-b2g/gaia/pull/19648

Comment 2

[Jose Manuel Cantera]

Comment on attachment 8428760 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/19648

Cancelling review as I believe the patch is not complete

Comment 3

[Fernando Campo (:fcampo)]

Comment on attachment 8428760 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/19648

Following the offline conversation, I checked all the thumbnail update process, and I think it's fine on the js.

Problem was the css background property being overwritten, which led to see only part of the image, but it's solved now.

Manual tests went fine.

Please review again

Comment 4

[Jose Manuel Cantera]

Comment on attachment 8428760 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/19648

thanks Fernando. Land once Travis is green

Comment 5

[Fernando Campo (:fcampo)]

merged on master - e8d276a4a260a62d0c3cbf30b54d45347fd45a05