Closed Bug 1012651 Opened 7 years ago Closed 7 years ago

[Contacts] Remove inline style for CSP compliance

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gerard-majax, Assigned: fcampo)

References

Details

Attachments

(1 file)

Depends on: 817674
Assignee: nobody → fernando.campo
Comment on attachment 8428760 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/19648

Cancelling review as I believe the patch is not complete
Attachment #8428760 - Flags: review?(jmcf)
Comment on attachment 8428760 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/19648

Following the offline conversation, I checked all the thumbnail update process, and I think it's fine on the js.

Problem was the css background property being overwritten, which led to see only part of the image, but it's solved now.

Manual tests went fine.

Please review again
Attachment #8428760 - Flags: review?(jmcf)
Comment on attachment 8428760 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/19648

thanks Fernando. Land once Travis is green
Attachment #8428760 - Flags: review?(jmcf) → review+
merged on master - e8d276a4a260a62d0c3cbf30b54d45347fd45a05
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.