1012689 - Trychooser should not select opt/debug by default and leave the user to choose

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Ed Morley [:emorley]]

Otherwise we end up with people not thinking/reading and making opt-only pushes when they didn't mean to, meaning things like leaks and assertions are only found when landing on inbound* (eg bug 979692 comment 71)

Comment 1

[Ed Morley [:emorley]]

Attachment: Add a "none" option and make it default

Adds a "none" option for the build type (both/opt/debug/none), makes it the default, and adds the red warning to the new option if still selected (same behaviour as for when "none" is selected for platforms). The label id "build_type-none" is so that the hyphen usage remains consistant with "platforms-none", but not that keen on the inconsistency in the file (naming + 4vs2 space indent, single vs double quotes etc).

Comment 2

[Ed Morley [:emorley]]

Attachment: Make indentation (slightly) more consistent

Tiny bit of cleanup; not doing the rest now :-)

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8426993 [details] [diff] [review]
Add a "none" option and make it default

SGTM, but I'm not a peer of this code AFAIK :)

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 8426993 [details] [diff] [review]
Add a "none" option and make it default

Review of attachment 8426993 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not a great reviewer for this either, but I can surely rubberstamp.

Comment 5

[Ed Morley [:emorley]]

Thanks!

remote:   https://hg.mozilla.org/build/tools/rev/0ae246586cf3
remote:   https://hg.mozilla.org/build/tools/rev/6756c8c5563a

Comment 6

[Ed Morley [:emorley]]

In production :-)