Closed Bug 1012689 Opened 8 years ago Closed 8 years ago

Trychooser should not select opt/debug by default and leave the user to choose

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

(Keywords: trychooser)

Attachments

(2 files)

Otherwise we end up with people not thinking/reading and making opt-only pushes when they didn't mean to, meaning things like leaks and assertions are only found when landing on inbound* (eg bug 979692 comment 71)
Adds a "none" option for the build type (both/opt/debug/none), makes it the default, and adds the red warning to the new option if still selected (same behaviour as for when "none" is selected for platforms). The label id "build_type-none" is so that the hyphen usage remains consistant with "platforms-none", but not that keen on the inconsistency in the file (naming + 4vs2 space indent, single vs double quotes etc).
Attachment #8426993 - Flags: review?(ryanvm)
Tiny bit of cleanup; not doing the rest now :-)
Attachment #8426995 - Flags: review?(ryanvm)
Keywords: trychooser
Comment on attachment 8426993 [details] [diff] [review]
Add a "none" option and make it default

SGTM, but I'm not a peer of this code AFAIK :)
Attachment #8426993 - Flags: review?(ryanvm)
Attachment #8426993 - Flags: review?(bhearsum)
Attachment #8426993 - Flags: feedback+
Attachment #8426995 - Flags: review?(ryanvm) → review?(bhearsum)
Comment on attachment 8426993 [details] [diff] [review]
Add a "none" option and make it default

Review of attachment 8426993 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not a great reviewer for this either, but I can surely rubberstamp.
Attachment #8426993 - Flags: review?(bhearsum) → review+
Attachment #8426995 - Flags: review?(bhearsum) → review+
Depends on: 1015063
Whiteboard: [waiting on bug 1015063]
In production :-)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [waiting on bug 1015063]
Component: Tools → General
You need to log in before you can comment on or make changes to this bug.