Closed
Bug 1012720
Opened 11 years ago
Closed 10 years ago
Fix deleting prototype getters in Fennec code
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 34
People
(Reporter: jchen, Assigned: madeti, Mentored)
Details
(Whiteboard: [lang=js])
Attachments
(1 file, 2 obsolete files)
2.82 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
Similar to bug 1010039, we have several places where we try to delete a prototype getter from an object and replace it with a value, which doesn't actually work because you can't delete a prototype getter from an instance.
Reporter | ||
Comment 1•10 years ago
|
||
Below are the places where we want to replace this usage,
> get foo() {
> delete this.foo;
> return this.foo = get_foo();
> },
with this,
> get foo() {
> if (!this._foo) {
> this._foo = get_foo();
> }
> return this._foo;
> }
http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/ContentDispatchChooser.js#22
http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/PaymentsUI.js#64
http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/ColorPicker.js#22
Assignee: nchen → nobody
Status: ASSIGNED → NEW
Whiteboard: [mentor=jchen][lang=js]
Updated•10 years ago
|
Mentor: nchen
Whiteboard: [mentor=jchen][lang=js] → [lang=js]
Reporter | ||
Comment 2•10 years ago
|
||
Ashish will be working on this bug.
Assignee: nobody → ashishmadeti
Reporter | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Comment 4•10 years ago
|
||
Changed the variable name (so that they are different from the property name).
Attachment #8464052 -
Attachment is obsolete: true
Reporter | ||
Comment 5•10 years ago
|
||
Attachment #8464060 -
Flags: review+
Assignee | ||
Comment 6•10 years ago
|
||
Updated the patch format.
Attachment #8464060 -
Attachment is obsolete: true
Attachment #8464067 -
Flags: review?(nchen)
Reporter | ||
Comment 7•10 years ago
|
||
Comment on attachment 8464067 [details] [diff] [review]
Patch for bug 1012720
Review of attachment 8464067 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good!
Attachment #8464067 -
Flags: review?(nchen) → review+
Reporter | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 8•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [lang=js] → [lang=js][fixed-in-fx-team]
Comment 9•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [lang=js][fixed-in-fx-team] → [lang=js]
Target Milestone: --- → Firefox 34
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•