1012720 - Fix deleting prototype getters in Fennec code

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Similar to bug 1010039, we have several places where we try to delete a prototype getter from an object and replace it with a value, which doesn't actually work because you can't delete a prototype getter from an instance.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Below are the places where we want to replace this usage,

>  get foo() {
>    delete this.foo;
>    return this.foo = get_foo();
>  },

with this,

>  get foo() {
>    if (!this._foo) {
>      this._foo = get_foo();
>    }
>    return this._foo;
>  }

http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/ContentDispatchChooser.js#22
http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/PaymentsUI.js#64
http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/ColorPicker.js#22

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Ashish will be working on this bug.

Comment 3

[Ashish Madeti [:madeti]]

Attachment: Patch for bug 1012720

Comment 4

[Ashish Madeti [:madeti]]

Attachment: Patch for bug 1012720

Changed the variable name (so that they are different from the property name).

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8464060 [details] [diff] [review]
Patch for bug 1012720

Thanks!

Comment 6

[Ashish Madeti [:madeti]]

Attachment: Patch for bug 1012720

Updated the patch format.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8464067 [details] [diff] [review]
Patch for bug 1012720

Review of attachment 8464067 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/e80cbf7d0c47

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e80cbf7d0c47