1012748 - remove nsIXPCSecurityManager

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Nathan Froyd [:froydnj]]

Bobby indicated in bug 996061 that this interface should just be removed.
Removing it also makes parts of that bug easier, so let's go ahead and do that.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: part 1 - remove unused mDefaultSecurityManager field

Getting rid of unused fields is a good starting point.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: part 2 - remove unnecessary includes of nsIXPCSecurityManager.h

Another minor cleanup before we get to the real patch.

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: part 3 - remove nsIXPCSecurityManager

Finally, the removal.  Nothing complicated here.

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 8424934 [details] [diff] [review]
part 1 - remove unused mDefaultSecurityManager field

Review of attachment 8424934 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch. I thought I removed this.

Comment 5

[Bobby Holley (:bholley)]

Comment on attachment 8424943 [details] [diff] [review]
part 3 - remove nsIXPCSecurityManager

Review of attachment 8424943 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 6

[Tom S [:evilpie]]

Comment on attachment 8424943 [details] [diff] [review]
part 3 - remove nsIXPCSecurityManager

Review of attachment 8424943 [details] [diff] [review]:
-----------------------------------------------------------------

::: caps/idl/nsIScriptSecurityManager.idl
@@ +15,5 @@
> +#include "jspubtd.h"
> +%}
> +
> +[ptr] native JSContextPtr(JSContext);
> +[ptr] native JSObjectPtr(JSObject);

I don't think you need this.

Comment 7

[Nathan Froyd [:froydnj]]

(In reply to Tom Schuster [:evilpie] from comment #6)
> Comment on attachment 8424943 [details] [diff] [review]
> part 3 - remove nsIXPCSecurityManager
> 
> Review of attachment 8424943 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: caps/idl/nsIScriptSecurityManager.idl
> @@ +15,5 @@
> > +#include "jspubtd.h"
> > +%}
> > +
> > +[ptr] native JSContextPtr(JSContext);
> > +[ptr] native JSObjectPtr(JSObject);
> 
> I don't think you need this.

You do, since the newly-added can* methods for that interface take native pointer types.  Without those, you get:

Traceback (most recent call last):
  File "/home/froydnj/src/gecko-dev.git/config/pythonpath.py", line 56, in <module>
    main(sys.argv[1:])
  File "/home/froydnj/src/gecko-dev.git/config/pythonpath.py", line 48, in main
    execfile(script, frozenglobals)
  File "/home/froydnj/src/gecko-dev.git/python/mozbuild/mozbuild/action/xpidl-process.py", line 92, in <module>
    main(sys.argv[1:])
  File "/home/froydnj/src/gecko-dev.git/python/mozbuild/mozbuild/action/xpidl-process.py", line 89, in main
    args.xptdir, args.depsdir, args.module, args.idls)
  File "/home/froydnj/src/gecko-dev.git/python/mozbuild/mozbuild/action/xpidl-process.py", line 43, in process
    idl.resolve([input_dir] + inc_paths, p)
  File "/home/froydnj/src/gecko-dev.git/xpcom/idl-parser/xpidl.py", line 287, in resolve
    p.resolve(self)
  File "/home/froydnj/src/gecko-dev.git/xpcom/idl-parser/xpidl.py", line 516, in resolve
    member.resolve(self)
  File "/home/froydnj/src/gecko-dev.git/xpcom/idl-parser/xpidl.py", line 834, in resolve
    p.resolve(self)
  File "/home/froydnj/src/gecko-dev.git/xpcom/idl-parser/xpidl.py", line 944, in resolve
    self.realtype = method.iface.idl.getName(self.type, self.location)
  File "/home/froydnj/src/gecko-dev.git/xpcom/idl-parser/xpidl.py", line 271, in getName
    raise IDLError("type '%s' not found" % id, location)
xpidl.IDLError: error: type 'JSContextPtr' not found, ../../../dist/idl/nsIScriptSecurityManager.idl line 28:40
    [noscript] void canCreateWrapper(in JSContextPtr aJSContext,

Comment 8

[Tom S [:evilpie]]

>error: type 'JSContextPtr' not found

Seems like you removed JSContextPtr and not JSObjectPtr.

Comment 9

[Nathan Froyd [:froydnj]]

(In reply to Tom Schuster [:evilpie] from comment #8)
> >error: type 'JSContextPtr' not found
> 
> Seems like you removed JSContextPtr and not JSObjectPtr.

Ah, my mistake, I misread and thought you were saying that all of those could be removed.  I think you're correct, and will remove those before landing.

Comment 10

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/846c9c999657
https://hg.mozilla.org/integration/mozilla-inbound/rev/561a17f55e0c
https://hg.mozilla.org/integration/mozilla-inbound/rev/913c11930bdb

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/846c9c999657
https://hg.mozilla.org/mozilla-central/rev/561a17f55e0c
https://hg.mozilla.org/mozilla-central/rev/913c11930bdb