1012795 - Replace editing mode cancel button telemetry extra with button id name

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Pass resource ID name with editing mode cancel event.

Might need some rebasing - haven't pulled yet.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8424999 [details] [diff] [review]
Pass resource ID name with editing mode cancel event.

Remember uplift

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/703fae2e244c

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8424999 [details] [diff] [review]
Pass resource ID name with editing mode cancel event.

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
  bug 997487
 
User impact if declined:
  None directly, but it will make it more difficult for us to analyze the UI telemetry scripts and make our data inconsistent across versions - i.e. wasted developer effort

Testing completed (on m-c, etc.):
  Local.
 
Risk to taking this patch (and alternatives if risky):
  Minimal - if we mess up, we're just messing up the telemetry event's extras field even more, but it's unlikely. 

String or IDL/UUID changes made by this patch: None

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/703fae2e244c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8d43d8f1a99e

Comment 7

[Flaviu Cos]

The following telemetry probe is logged when tapping on cancel button:
SendUIEvent: action = cancel.1 method = actionbar timestamp = 1084109 extras = edit_cancel

Verified as fixed in builds:
- 32.0a1 (2014-05-25);
- 31.0a2 (2014-05-25);

Device: Alcatel One Touch 8008D (Android 4.1.2).