Closed
Bug 1012795
Opened 10 years ago
Closed 10 years ago
Replace editing mode cancel button telemetry extra with button id name
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(firefox31 verified, firefox32 verified)
VERIFIED
FIXED
Firefox 32
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(1 file)
1.31 KB,
patch
|
mfinkle
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•10 years ago
|
status-firefox31:
--- → affected
status-firefox32:
--- → affected
Assignee | ||
Comment 1•10 years ago
|
||
Might need some rebasing - haven't pulled yet.
Attachment #8424999 -
Flags: review?(mark.finkle)
Comment 2•10 years ago
|
||
Comment on attachment 8424999 [details] [diff] [review] Pass resource ID name with editing mode cancel event. Remember uplift
Attachment #8424999 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/703fae2e244c
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8424999 [details] [diff] [review] Pass resource ID name with editing mode cancel event. [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 997487 User impact if declined: None directly, but it will make it more difficult for us to analyze the UI telemetry scripts and make our data inconsistent across versions - i.e. wasted developer effort Testing completed (on m-c, etc.): Local. Risk to taking this patch (and alternatives if risky): Minimal - if we mess up, we're just messing up the telemetry event's extras field even more, but it's unlikely. String or IDL/UUID changes made by this patch: None
Attachment #8424999 -
Flags: approval-mozilla-aurora?
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/703fae2e244c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Updated•10 years ago
|
Updated•10 years ago
|
Attachment #8424999 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•10 years ago
|
||
The following telemetry probe is logged when tapping on cancel button: SendUIEvent: action = cancel.1 method = actionbar timestamp = 1084109 extras = edit_cancel Verified as fixed in builds: - 32.0a1 (2014-05-25); - 31.0a2 (2014-05-25); Device: Alcatel One Touch 8008D (Android 4.1.2).
Updated•10 years ago
|
Blocks: mobile-ui-telemetry
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•