1012807 - convert nsMsgUtils.cpp::MsgStripQuotedPrintable(unsigned char *src) to 'const char*'

Status: RESOLVED WORKSFORME

(MailNews Core :: Backend, defect)

Description

[:aceman]

+++ This bug was initially created as a clone of Bug #853159 comment 32 +++

[e-mail] 2014-05-19 00:27:55 CEST

(In reply to aceman from comment #30)
> > [Given that there are hardly any uses of token left, you might as well just
> > use src + srcIdx + 1 directly.]
> Yes, except the ugly cast from unsigned char* to const char*.
Oops, both callers ugly cast from const char* to unsigned char* (which is worse, because it's casting away const!) Obviously that needs to be fixed in a separate bug, but that will therefore simplify these uses too.

Comment 1

[:aceman]

Attachment: patch

Comment 2

[[e-mail]]

Comment on attachment 8425003 [details] [diff] [review]
patch

Actually const char* is also wrong, because we're still casting away const (this time in MsgStripQuotedPrintable itself). You have three choices:
* Pass char* and use BeginWriting() instead of get()
* Pass nsCString& and use BeginWriting inside MsgStripQuotedPrintable
* Pass nsACString& and use string manipulation methods
Note that for the latter two you can also update the length at the same time.

Comment 3

[Hartmut Welpmann [:welpy-cw]]

This was fixed by bug 1408175.