1012811 - Color swatch background doesn't stay in the right place while scrolling

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Tim Nguyen :ntim]

STR :
- Open inspector
- Select element with color related css
- scroll the computed/rules view

Comment 1

[Tim Nguyen :ntim]

Screenshot : http://images.devs-on.net/Image/3OqcTgcLUBcVTxr1-Region.png

Comment 2

[Brian Grinstead [:bgrins]]

(In reply to Tim Nguyen [:ntim] from comment #0)
> STR :
> - Open inspector
> - Select element with color related css
> - scroll the computed/rules view

I only see this on the computed view, but it is a really weird effect

Comment 3

[Tim Nguyen :ntim]

(In reply to Brian Grinstead [:bgrins] from comment #2)
> (In reply to Tim Nguyen [:ntim] from comment #0)
> > STR :
> > - Open inspector
> > - Select element with color related css
> > - scroll the computed/rules view
> 
> I only see this on the computed view, but it is a really weird effect

Yep, you're right, it's just in the computed view. But I still included some code to avoid this on the rules view.

Comment 4

[Tim Nguyen :ntim]

Attachment: Patch v1

This seems to fix the issue.

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8425012 [details] [diff] [review]
Patch v1

Review of attachment 8425012 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, fixes the problem.  In addition to the noted change, can you also remove the trailing whitespace that got introduced after .link:hover in computedview.css in latest fx-team?

::: browser/themes/shared/devtools/ruleview.css
@@ +130,5 @@
>    background-size: 12px 12px;
>    background-position: 0 0, 6px 6px;
>    position: absolute;
>    border-radius: 50%;
>    width: 1em;

we shouldn't need width/height to be set anymore with the top/bottom/left/right set to 0.

Comment 6

[Tim Nguyen :ntim]

(In reply to Brian Grinstead [:bgrins] from comment #5)
> Comment on attachment 8425012 [details] [diff] [review]
> Patch v1
> 
> Review of attachment 8425012 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Nice, fixes the problem.  In addition to the noted change, can you also
> remove the trailing whitespace that got introduced after .link:hover in
> computedview.css in latest fx-team?
Sure :)

Comment 7

[Tim Nguyen :ntim]

Attachment: Patch v1.1

Addressed comments.

Comment 8

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/f463040ec391

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f463040ec391