1013085 - change gaia-header folder name

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

Before we have too many implementations, I would like to quickly rename the custom elements to match our platform standards. This will likely cause some conflicts with your branchs, and I apologize for that, but it is important that we adhere to our file patterns.

We are supposed to be using underscores for file names and folders: https://developer.mozilla.org/en-US/Firefox_OS/Platform/Gaia/Hacking#Coding_style_basics

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Yan, Wilson - could you guys give this a review stamp when you have the time? Thanks!

Apologies for not having a linter about this. It is a bit weird to have a syntax standard without a linter, so hopefully we'll get one soon.

Comment 2

[Wilson Page [:wilsonpage]]

Comment on attachment 8425274 [details] [review]
Github pull request

Urgh, underscores are so gross, especially as dashes match our element names. But I guess I'm too late to the game to argue this.

<gaia_header>:'(</gaia_header>

Comment 3

[Kevin Grandon :kgrandon]

I understand - and I am going to miss the fact that it doesn't match our elements exactly, but I guess this is also the problem with *every* JS class we currently have. Thanks for the review, and sorry we have to make the change for consistency.

Comment 4

[Yan Or]

Comment on attachment 8425274 [details] [review]
Github pull request

Works for me.

Comment 5

[Kevin Grandon :kgrandon]

Thanks guys. Again - hopefully I didn't cause too many rebase problems. Beers on me if I did.

Landed: https://github.com/mozilla-b2g/gaia/commit/1609e724e10ca78b9f1523b94a7862fdbed496be