1013092 - Remove logo in remote video stream

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Romain Testard [:RT]]

Currently a logo appears in the top left corner of the remote video window.
This logo should be removed using the following code sample:

var publisherProperties = {bugDisplayMode: "off"};
var publisher = OT.initPublisher(targetElement,
                                 publisherProperties);

Comment 1

[Maire Reavy [:mreavy]]

Hey Mark -- Can you try inserting the 2 lines of code above and see if it works (i.e. removes the logo in the top left corner of the remote video window)?    If so, I'd like to check it into the code.  If it doesn't work or if you need more info, let me know.  Thanks.

Comment 2

[Mark Banner (:standard8)]

Yep, will try.

Comment 3

[Mark Banner (:standard8)]

It doesn't work. I've altered our code to do the equivalent, and it isn't working on either desktop or web client.

I can change the default in the sdk to "off" and that works for publisher video, but not for subscriber.

Comment 4

[Mark Banner (:standard8)]

Ok, Romain's just chatted to me over irc, and given me a slight alternative:

var publisherProperties = {style: { bugDisplayMode: "off" } };

This does work, and is consistent with the sdk guide for the initPublisher/subscribe methods.

I'll get it on a PR.

Comment 5

[Mark Banner (:standard8)]

Attachment: Link to Github pull-request: https://github.com/mozilla/loop-client/pull/31

Comment 6

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8425430 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop-client/pull/31

LGTM

Comment 7

[Mark Banner (:standard8)]

https://github.com/mozilla/loop-client/commit/3942f7eda2a4b03aede289b2b3317a4c683ac56c

I've updated the loop-dev server with this, so it is already there. Desktop clients will pick it up as they update to latest etc.

Comment 8

[Mark Banner (:standard8)]

https://hg.mozilla.org/projects/elm/rev/6c057facaf0e

Comment 9

[Mark Banner (:standard8)]

https://hg.mozilla.org/mozilla-central/rev/6c057facaf0e

Comment 10

[u279076]

Untracking for QA. Please needinfo me to request specific testing.