1013096 - [Calendar] Month View: don't hard-code date structures

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Francesco Lodolo [:flod]]

Noticed today while testing Gaia master: date format in the new month view is wrong in Italian ("Full_day, short_month day_number" doesn't make sense).

Then I realized I'm not responsible for this error
https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/js/views/months_day.js#L46-L49

If you need it, please define a new localizable string for this date format, don't hard-code it.

One other note about the changes landed in bug 951069: text-transform: uppercase; is bad (see bug 830002).

Comment 1

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19692

created a new date format specific for the MonthsDay View header.

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8429590 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19692

Switching to feedback since I'm not a real reviewer.

I left a comment on GH about the key name (very minor nit), this is definitely better.

Code-wise (which is not really my area): I think we're trying to move away from using .innerHTML (bug 992473), but that could be part of a more general code update for Calendar.
https://groups.google.com/forum/#!topic/mozilla.dev.gaia/YfkmG_FTA3k

Comment 3

[Evan Tseng [:evanxd]]

Comment on attachment 8429590 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19692

Hi Miller,

Nice works!
Just a nit for naming of `months-day-header` label.

Comment 4

[Miller Medeiros [:millermedeiros]]

landed into master! https://github.com/mozilla-b2g/gaia/commit/124f3bcf4d35763b9acfbc2c4bd1b3eeab170fa9