1013120 - [B2G][Calendar] Month View: should use calendar colors for dots and alarm icons

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Edward Chen[:edchen]]

Attachment: Screenshot

[Environment]
Gaia      8a2352d5b7be27ec4b1ea18c680ebcd0b6d34348
Gecko     https://hg.mozilla.org/mozilla-central/rev/cb9f34f73ebe
BuildID   20140519160202
Version   32.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013

[Reproduce]
1. Launch calendar app
2. Set google account and Yahoo account
3. Add a event with google account
4. Add a event with Yajoo account

[Actual result]
Dots color are the same. 

[Expect result]
Dots color should be different with different account

Comment 1

[Miller Medeiros [:millermedeiros]]

do we also need to change the color of the alarms?

Comment 2

[Edward Chen[:edchen]]

I think that it's unnecessary. Maight be we can consult UX team about this question.

Hi Harly,
As Miller mentioned, could you please give some feedback on this case.

Comment 3

[Harly Hsu[:harly]]

Hi Edward,
After checking with Peko, to have alarm color the same as account color was part of the visual design. Thanks.

Comment 4

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19499

since it's a "simple fix" I went ahead and changed it.

Comment 5

[Harly Hsu[:harly]]

Comment on attachment 8426505 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19499

Nice job, Miller.
Thanks

Comment 6

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8426505 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19499

Great work Miller and thanks for sticking with it :)

Comment 7

[Gareth Aye [:gaye] (back from PTO)]

Landed on master https://github.com/mozilla-b2g/gaia/commit/bcfc33561c2f795b082b06e7ecefd8e135d380b7

Comment 8

[Gareth Aye [:gaye] (back from PTO)]

(In reply to Gareth Aye [:gaye] from comment #6)
> Comment on attachment 8426505 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19499
> 
> Great work Miller and thanks for sticking with it :)

Er I meant this comment for the week view, but this changeset also looks good.

Comment 9

[Edward Chen[:edchen]]

[Environment]
Gaia      6a391274cd436f8f0d1fad2db8c6b4805703259c
Gecko     https://hg.mozilla.org/mozilla-central/rev/545c35907eff
BuildID   20140526160203
Version   32.0a1
ro.build.version.incremental=76
ro.build.date=Mon Apr 14 14:02:50 CST 2014

[Result]
Pass