1013279 - Whenever a app installation fails, a uncatch error is thrown by Task.jsm

Status: RESOLVED DUPLICATE of bug 997717

(Core Graveyard :: DOM: Apps, defect)

Description

[Antonio Manuel Amaya Calvo (:amac)]

STR:

1. Try to install any application that fails (invalid signature, invalid store). For example, try running the mochitests for dom/apps/tests.

Expected:
The installation fails silently

Actual: 
The installation fails, but there's a error dumped that says:

 0:11.38 *************************
 0:11.38 A coding exception was thrown and uncaught in a Task.
 0:11.38 
 0:11.38 Full message: TypeError: undefined has no properties
 0:11.38 Full stack: this.DOMApplicationRegistry.startDownload<@resource://gre/modules/Webapps.jsm:1277:1
 0:11.38 TaskImpl_run@resource://gre/modules/Task.jsm:282:13
 0:11.38 Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:863:11
 0:11.38 this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:742:7
 0:11.38 
 0:11.38 *************************

Comment 1

[Antonio Manuel Amaya Calvo (:amac)]

Attachment: Return a rejected promise in all cases where the download doesn't suceed

The problem is that promise.then(fulfilledCB, rejectedCB) also returns a promise, with the fulfillment state resulting from the execution of either fulfilledCB or rejectedCB. In this case, rejectedCB is _revertDownloadPackage, which succeeded always, and made the next .then() on the chain to try to execute the fulfillment CB (onDownloadPackage), which then failed because the returned value was undefined.

Now when the promise should be rejected we always throw.

Comment 2

[Marco Castelluccio [:marco]]

This is a duplicate of bug 997717.