Closed Bug 1013464 Opened 12 years ago Closed 12 years ago

Intermittent video_test.js | Video App Unit Tests #showPlayer flows "after all" hook | TypeError: dom.player is null (http://video.gaiamobile.org:8080/js/video.js?time=NNNNNNNN:1096)

Categories

(Firefox OS Graveyard :: Gaia::Video, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Video
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ryanvm, Assigned: rnicoletti)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Pull request: https://github.com/mozilla-b2g/gaia/pull/20636
46 bytes, text/x-github-pull-request
johnhu
: review+
Details | Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=40018700&tree=Mozilla-Inbound b2g_ubuntu64_vm mozilla-inbound opt test gaia-unit on 2014-05-20 07:10:27 PDT for push e0c610619df3 slave: tst-linux64-spot-975 07:54:01 INFO - gaia-unit-tests TEST-START | video/test/unit/video_test.js | #showPlayer flows 07:54:01 INFO - gaia-unit-tests TEST-PASS | video/test/unit/video_test.js | Video App Unit Tests #showPlayer flows #showPlayer: !play, !fullscreen, show controls - curr video !exist, video !seeking 07:54:01 INFO - gaia-unit-tests TEST-PASS | video/test/unit/video_test.js | Video App Unit Tests #showPlayer flows #showPlayer: !play, !fullscreen, show controls - curr video !exist, video seeking 07:54:02 INFO - gaia-unit-tests TEST-PASS | video/test/unit/video_test.js | Video App Unit Tests #showPlayer flows #showPlayer: !play, !fullscreen, show controls - curr video does not exist, video not seeking 07:54:02 INFO - gaia-unit-tests TEST-PASS | video/test/unit/video_test.js | Video App Unit Tests #showPlayer flows #showPlayer: play, !fullscreen, show controls 07:54:02 INFO - gaia-unit-tests TEST-PASS | video/test/unit/video_test.js | Video App Unit Tests #showPlayer flows #showPlayer: play, fullscreen, show controls 07:54:03 INFO - gaia-unit-tests TEST-PASS | video/test/unit/video_test.js | Video App Unit Tests #showPlayer flows #showPlayer: play, fullscreen, !show controls 07:54:03 INFO - gaia-unit-tests TEST-PASS | video/test/unit/video_test.js | Video App Unit Tests #showPlayer flows #showPlayer: selected video has metadata, video not at end 07:54:03 INFO - gaia-unit-tests TEST-PASS | video/test/unit/video_test.js | Video App Unit Tests #showPlayer flows #showPlayer: selected video has metadata, video at end 07:54:04 INFO - gaia-unit-tests TEST-PASS | video/test/unit/video_test.js | Video App Unit Tests #showPlayer flows #showPlayer: selected video has metadata, first time played 07:54:04 INFO - gaia-unit-tests TEST-PASS | video/test/unit/video_test.js | Video App Unit Tests #showPlayer flows #showPlayer: selected video has no metadata, no title 07:54:04 INFO - gaia-unit-tests TEST-PASS | video/test/unit/video_test.js | Video App Unit Tests #showPlayer flows #showPlayer: selected video has no metadata, has title 07:54:05 INFO - JavaScript error: http://video.gaiamobile.org:8080/js/video.js?time=1400597636634, line 1096: dom.player is null 07:54:05 INFO - gaia-unit-tests TEST-END | video/test/unit/video_test.js | #showPlayer flows 07:54:05 INFO - gaia-unit-tests TEST-UNEXPECTED-FAIL | video/test/unit/video_test.js | Video App Unit Tests #showPlayer flows "after all" hook | TypeError: dom.player is null (http://video.gaiamobile.org:8080/js/video.js?time=1400597636634:1096) 07:54:05 INFO - gaia-unit-tests INFO | stack trace: 07:54:05 INFO - Error: TypeError: dom.player is null (http://video.gaiamobile.org:8080/js/video.js?time=1400597636634:1096) 07:54:05 INFO - at onerror (http://video.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4959:7) 07:54:05 INFO - gaia-unit-tests INFO | suite results (pass/fail): 26/1 07:54:05 INFO - gaia-unit-tests TEST-END | video/test/unit/thumbnail_item_test.js | Video App Unit Tests 07:54:06 INFO - JavaScript warning: http://video.gaiamobile.org:8080/common/vendor/chai/chai.js?time=1400597646419, line 1135: mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create
Assignee: nobody → rnicoletti
Status: NEW → ASSIGNED
Summary: Intermittent video/test/unit/video_test.js | Video App Unit Tests #showPlayer flows "after all" hook | TypeError: dom.player is null (http://video.gaiamobile.org:8080/js/video.js?time=1400597636634:1096) → Intermittent video_test.js | Video App Unit Tests #showPlayer flows "after all" hook | TypeError: dom.player is null (http://video.gaiamobile.org:8080/js/video.js?time=NNNNNNNN:1096)
FWIW, this has been happening as far back as Feb 7 (c9d3355e3d221d9489efca20891c4a62ac68fb2f), surely further than that; the issue is not related to any recent change to video.js or video_test.js.
The main change was to load video.js after loading html into DOM. See PR for details.
Attachment #8442254 - Flags: review?(johu)
Comment on attachment 8442254 [details] [review] Pull request: https://github.com/mozilla-b2g/gaia/pull/20636 Thanks for this patch. I had left some comments at PR. Please check them before landing.
Attachment #8442254 - Flags: review?(johu) → review+
Master: https://github.com/russnicoletti/gaia/commit/0881d437b0752c7d00b67bb63f459ba8340f3914
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: