1013472 - Make it possible to edit app/version status in the lookup tool

Status: RESOLVED FIXED

(Marketplace Graveyard :: Admin Tools, defect, P2)

Description

[Andrew Williamson [:eviljeff]]

It seems a recent commit has removed the app (titled addon) manage search box in the /admin page [1].  My strong suspicion is one of the repoman bugs [2].  This search box is used for apps on Marketplace, despite it saying addon search.

We (myself and Lisa) need it to be able to access the manage pages for apps, which is the only place we can manually change the status of an app and/or the versions.  Typical use cases for these changes are reversing incorrect reviewer reviews and fixing apps that have gotten stuck in the wrong state due to a bug.  Its also the place we would blocklist apps.

Option a: revert the parts of [2] that are needed to make the search work.
Option b: replace the (really ancient) functionality entirely - see bug 782929

[1] https://marketplace.firefox.com/admin
[2] https://github.com/mozilla/zamboni/commit/16dd9751a48369b1d9d42baa93a005d67678610b

Comment 1

[Wil Clouser [:clouserw]]

Can you talk about why the lookup tool wouldn't work for this?  Can we adjust the lookup tool to do whatever you need here?  I'd rather not maintain two different tools.

Comment 2

[Andrew Williamson [:eviljeff]]

(In reply to Wil Clouser [:clouserw] from comment #1)
> Can you talk about why the lookup tool wouldn't work for this?  

The lookup tool does the search part, but not the modifying statuses part.

> Can we adjust the lookup tool to do whatever you need here?  I'd rather not
> maintain two different tools.

Yes! I proposed in bug 782929 that the missing functionality be added into the developer manage status page (so all status type changes live in one place) but I've no objection against it being added to the lookup results pages directly.

Comment 3

[Wil Clouser [:clouserw]]

Attachment: lookup_status.png

I talked with eviljeff and the attached illustrates what he is requesting.  If the user has Apps:Edit permissions, they should see some dropdowns for statuses.  Let's save via AJAX but he specifically requests the whole page doesn't reload on each change.

Comment 4

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/730a8188836d1c0e6cdf66092e333c16da0cb3d1

Comment 5

[Andrew Williamson [:eviljeff]]

some of the text is wrong - 

the file dropdown status for moz-disabled should be 'obsolete' instead of disabled.
https://github.com/mozilla/zamboni/blob/master/apps/constants/base.py#L53

and when I changed to published the pop up box said 'public' instead of 'Published'

Comment 6

[Mathieu Pillard [:mat]]

I adjusted the dropdown for the files in https://github.com/mozilla/zamboni/commit/68c3c3ab6c6b8ec9ff05904e4084cc3b290247e2

The notification box I left as-is, it's displaying the status returned by the API, which is not really meant to be displayed to humans, but since it's an admin-only tool I took the lazy route :)